public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb: remove an out of date comment about disp_del_at_next_stop
@ 2023-02-28 11:09 Andrew Burgess
0 siblings, 0 replies; only message in thread
From: Andrew Burgess @ 2023-02-28 11:09 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=02aadca4fbeadbab6584222ca78dbc24c79f5229
commit 02aadca4fbeadbab6584222ca78dbc24c79f5229
Author: Andrew Burgess <aburgess@redhat.com>
Date: Thu Feb 16 19:07:12 2023 +0000
gdb: remove an out of date comment about disp_del_at_next_stop
Delete an out of date comment about disp_del_at_next_stop, the comment
says:
/* NOTE drow/2003-09-08: This state only exists for removing
watchpoints. It's not clear that it's necessary... */
I'm sure this was true when the comment was added, but today the
disp_del_at_next_stop state is not just used for deleting watchpoints,
which leaves us with "It's not clear that it's necessary...", which
doesn't really help at all.
And then this comment is located on one random place where
disp_del_at_next_stop is used, rather than at its definition site.
Lets just delete the comment.
No user visible changes after this commit.
Reviewed-By: Pedro Alves <pedro@palves.net>
Diff:
---
gdb/breakpoint.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index ebf9d8f1349..7d11f7199fe 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -2938,8 +2938,6 @@ insert_bp_location (struct bp_location *bl,
}
else if (bl->loc_type == bp_loc_hardware_watchpoint
- /* NOTE drow/2003-09-08: This state only exists for removing
- watchpoints. It's not clear that it's necessary... */
&& bl->owner->disposition != disp_del_at_next_stop)
{
int val;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-28 11:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-28 11:09 [binutils-gdb] gdb: remove an out of date comment about disp_del_at_next_stop Andrew Burgess
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).