public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Fix gdb.rust/watch.exp on ppc64le
@ 2023-02-28 12:32 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2023-02-28 12:32 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7226dd9faabbe6987e5910483374752ca7934255

commit 7226dd9faabbe6987e5910483374752ca7934255
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Feb 28 13:32:23 2023 +0100

    [gdb/testsuite] Fix gdb.rust/watch.exp on ppc64le
    
    On x86_64-linux, I have:
    ...
    (gdb) watch -location y^M
    Hardware watchpoint 2: -location y^M
    (gdb) PASS: gdb.rust/watch.exp: watch -location y
    ...
    but on powerpc64le-linux, I run into:
    ...
    (gdb) watch -location y^M
    Watchpoint 2: -location y^M
    (gdb) FAIL: gdb.rust/watch.exp: watch -location y
    ...
    due to the regexp matching "Hardware watchpoint" but not "Watchpoint":
    ...
    gdb_test "watch -location y" ".*watchpoint .* -location .*"
    ...
    
    Fix this by making the regexp less restrictive.
    
    Tested on x86_64-linux and powerpc64le-linux.

Diff:
---
 gdb/testsuite/gdb.rust/watch.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.rust/watch.exp b/gdb/testsuite/gdb.rust/watch.exp
index 83cb41cc1eb..43c88f8a1fc 100644
--- a/gdb/testsuite/gdb.rust/watch.exp
+++ b/gdb/testsuite/gdb.rust/watch.exp
@@ -30,4 +30,4 @@ if {![runto ${srcfile}:$line]} {
 }
 
 # Just setting a watchpoint was enough to trigger the bug.
-gdb_test "watch -location y" ".*watchpoint .* -location .*"
+gdb_test "watch -location y" ".*\[wW\]atchpoint .* -location .*"

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2023-02-28 12:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-28 12:32 [binutils-gdb] [gdb/testsuite] Fix gdb.rust/watch.exp on ppc64le Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).