public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Fix some value comments Date: Thu, 2 Mar 2023 15:15:36 +0000 (GMT) [thread overview] Message-ID: <20230302151536.5108B3858C62@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2641391a87d5e6029cb1f083fd42926f668094eb commit 2641391a87d5e6029cb1f083fd42926f668094eb Author: Tom Tromey <tromey@adacore.com> Date: Wed Mar 1 14:29:28 2023 -0700 Fix some value comments I noticed a very stale comment in valarith.c. This patch fixes a few comments in this area. Reviewed-By: Andrew Burgess <aburgess@redhat.com> Diff: --- gdb/valarith.c | 6 +++++- gdb/value.h | 5 +++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/gdb/valarith.c b/gdb/valarith.c index 6ea0cd9e8d1..4c2b44360bb 100644 --- a/gdb/valarith.c +++ b/gdb/valarith.c @@ -1884,7 +1884,7 @@ value_less (struct value *arg1, struct value *arg2) } } \f -/* The unary operators +, - and ~. They free the argument ARG1. */ +/* See value.h. */ struct value * value_pos (struct value *arg1) @@ -1902,6 +1902,8 @@ value_pos (struct value *arg1) error (_("Argument to positive operation not a number.")); } +/* See value.h. */ + struct value * value_neg (struct value *arg1) { @@ -1948,6 +1950,8 @@ value_neg (struct value *arg1) error (_("Argument to negate operation not a number.")); } +/* See value.h. */ + struct value * value_complement (struct value *arg1) { diff --git a/gdb/value.h b/gdb/value.h index c3eb96bf143..d83c4ab3674 100644 --- a/gdb/value.h +++ b/gdb/value.h @@ -1206,10 +1206,15 @@ extern struct value *value_ref (struct value *arg1, enum type_code refcode); extern struct value *value_assign (struct value *toval, struct value *fromval); +/* The unary + operation. */ extern struct value *value_pos (struct value *arg1); +/* The unary - operation. */ extern struct value *value_neg (struct value *arg1); +/* The unary ~ operation -- but note that it also implements the GCC + extension, where ~ of a complex number is the complex + conjugate. */ extern struct value *value_complement (struct value *arg1); extern struct value *value_struct_elt (struct value **argp,
reply other threads:[~2023-03-02 15:15 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230302151536.5108B3858C62@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).