public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Fix some value comments
@ 2023-03-02 15:15 Tom Tromey
0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2023-03-02 15:15 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2641391a87d5e6029cb1f083fd42926f668094eb
commit 2641391a87d5e6029cb1f083fd42926f668094eb
Author: Tom Tromey <tromey@adacore.com>
Date: Wed Mar 1 14:29:28 2023 -0700
Fix some value comments
I noticed a very stale comment in valarith.c. This patch fixes a few
comments in this area.
Reviewed-By: Andrew Burgess <aburgess@redhat.com>
Diff:
---
gdb/valarith.c | 6 +++++-
gdb/value.h | 5 +++++
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/gdb/valarith.c b/gdb/valarith.c
index 6ea0cd9e8d1..4c2b44360bb 100644
--- a/gdb/valarith.c
+++ b/gdb/valarith.c
@@ -1884,7 +1884,7 @@ value_less (struct value *arg1, struct value *arg2)
}
}
\f
-/* The unary operators +, - and ~. They free the argument ARG1. */
+/* See value.h. */
struct value *
value_pos (struct value *arg1)
@@ -1902,6 +1902,8 @@ value_pos (struct value *arg1)
error (_("Argument to positive operation not a number."));
}
+/* See value.h. */
+
struct value *
value_neg (struct value *arg1)
{
@@ -1948,6 +1950,8 @@ value_neg (struct value *arg1)
error (_("Argument to negate operation not a number."));
}
+/* See value.h. */
+
struct value *
value_complement (struct value *arg1)
{
diff --git a/gdb/value.h b/gdb/value.h
index c3eb96bf143..d83c4ab3674 100644
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -1206,10 +1206,15 @@ extern struct value *value_ref (struct value *arg1, enum type_code refcode);
extern struct value *value_assign (struct value *toval,
struct value *fromval);
+/* The unary + operation. */
extern struct value *value_pos (struct value *arg1);
+/* The unary - operation. */
extern struct value *value_neg (struct value *arg1);
+/* The unary ~ operation -- but note that it also implements the GCC
+ extension, where ~ of a complex number is the complex
+ conjugate. */
extern struct value *value_complement (struct value *arg1);
extern struct value *value_struct_elt (struct value **argp,
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-03-02 15:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-02 15:15 [binutils-gdb] Fix some value comments Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).