public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Fix gdb.tui/completion.exp for local-remote-host-notty
@ 2023-03-13 16:20 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2023-03-13 16:20 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0020d62fb3cd384d5f3d23f1877d0709a07a7d2b
commit 0020d62fb3cd384d5f3d23f1877d0709a07a7d2b
Author: Tom de Vries <tdevries@suse.de>
Date: Mon Mar 13 17:20:09 2023 +0100
[gdb/testsuite] Fix gdb.tui/completion.exp for local-remote-host-notty
When running test-case gdb.tui/completion.exp with host board
local-remote-host-notty and target board native-gdbserver, I get:
...
FAIL: gdb.tui/completion.exp: completion of layout names: \
tab completion (timeout)
...
The test-case contains a few tests that do tab completion, which requires
readline, which is unavailable with host board local-remote-host-notty.
Fix this by adding the missing check for readline_is_used.
Tested on x86_64-linux.
Diff:
---
gdb/testsuite/gdb.tui/completion.exp | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/gdb/testsuite/gdb.tui/completion.exp b/gdb/testsuite/gdb.tui/completion.exp
index 0a959b4ff8b..85abd4a958b 100644
--- a/gdb/testsuite/gdb.tui/completion.exp
+++ b/gdb/testsuite/gdb.tui/completion.exp
@@ -48,12 +48,15 @@ proc test_tab_completion {input_line expected_re} {
}
}
-with_test_prefix "completion of layout names" {
- test_tab_completion "layout" "asm *next *prev *regs *split *src *"
-}
+if { [readline_is_used] } {
+ with_test_prefix "completion of layout names" {
+ test_tab_completion "layout" "asm *next *prev *regs *split *src *"
+ }
-with_test_prefix "completion of focus command" {
- test_tab_completion "focus" "cmd *next *prev *src *"
+
+ with_test_prefix "completion of focus command" {
+ test_tab_completion "focus" "cmd *next *prev *src *"
+ }
}
# Now run some completion tests when TUI mode is enabled.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-03-13 16:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-13 16:20 [binutils-gdb] [gdb/testsuite] Fix gdb.tui/completion.exp for local-remote-host-notty Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).