public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Fix gdb.python/tui-window-factory.exp for remote host
@ 2023-03-13 16:20 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2023-03-13 16:20 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7fee66abd3fd69a0c4dc6c8dcd9aa49eede3864e
commit 7fee66abd3fd69a0c4dc6c8dcd9aa49eede3864e
Author: Tom de Vries <tdevries@suse.de>
Date: Mon Mar 13 17:20:09 2023 +0100
[gdb/testsuite] Fix gdb.python/tui-window-factory.exp for remote host
When running gdb.python/tui-window.exp with host board
local-remote-host-notty and target board native-gdbserver, I get:
...
FAIL: gdb.python/tui-window-factory.exp: msg_2: \
check test_window box (box check: ul corner is l, not +)
...
The problem is that the result of Term::prepare_for_tui is not checked.
Fix this by adding the missing check.
Tested on x86_64-linux.
Diff:
---
gdb/testsuite/gdb.python/tui-window-factory.exp | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.python/tui-window-factory.exp b/gdb/testsuite/gdb.python/tui-window-factory.exp
index 3e898d01c7b..e3b403bdea0 100644
--- a/gdb/testsuite/gdb.python/tui-window-factory.exp
+++ b/gdb/testsuite/gdb.python/tui-window-factory.exp
@@ -32,7 +32,10 @@ set pyfile [gdb_remote_download host \
${srcdir}/${subdir}/${gdb_test_file_name}.py]
Term::clean_restart 24 80
-Term::prepare_for_tui
+if { ![Term::prepare_for_tui] } {
+ unsupported "TUI not supported"
+ return
+}
gdb_test "source ${pyfile}" "Python script imported" \
"import python scripts"
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-03-13 16:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-13 16:20 [binutils-gdb] [gdb/testsuite] Fix gdb.python/tui-window-factory.exp for remote host Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).