public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Fix re-used exec in gdb.arch/ftrace-insn-reloc.exp
@ 2023-03-15 15:38 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2023-03-15 15:38 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5d47e20b22ad00ea059afca86e12c6f0f06e2d4f

commit 5d47e20b22ad00ea059afca86e12c6f0f06e2d4f
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed Mar 15 16:38:03 2023 +0100

    [gdb/testsuite] Fix re-used exec in gdb.arch/ftrace-insn-reloc.exp
    
    In test-case gdb.arch/ftrace-insn-reloc.exp we generate two executables with
    the same name, which is confusing and known to cause trouble.
    
    Fix this by making the executable names unique.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.arch/ftrace-insn-reloc.exp | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/gdb/testsuite/gdb.arch/ftrace-insn-reloc.exp b/gdb/testsuite/gdb.arch/ftrace-insn-reloc.exp
index a353f386ec0..a00c4dbe2ff 100644
--- a/gdb/testsuite/gdb.arch/ftrace-insn-reloc.exp
+++ b/gdb/testsuite/gdb.arch/ftrace-insn-reloc.exp
@@ -15,13 +15,11 @@
 load_lib "trace-support.exp"
 
 standard_testfile insn-reloc.c
-set executable $testfile
-set expfile $testfile.exp
 
 # Some targets have leading underscores on assembly symbols.
 set additional_flags [gdb_target_symbol_prefix_flags]
 
-if [prepare_for_testing "failed to prepare" $executable $srcfile \
+if [prepare_for_testing "failed to prepare" $testfile-no-ipa $srcfile \
 	[list debug $additional_flags]] {
     return -1
 }
@@ -47,7 +45,7 @@ if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
     untested "failed to compile"
     return -1
 }
-clean_restart ${executable}
+clean_restart $testfile
 
 if ![runto_main] {
     return 0

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-15 15:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-15 15:38 [binutils-gdb] [gdb/testsuite] Fix re-used exec in gdb.arch/ftrace-insn-reloc.exp Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).