public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] libctf: fix a comment typo
@ 2023-03-24 14:08 Nick Alcock
0 siblings, 0 replies; only message in thread
From: Nick Alcock @ 2023-03-24 14:08 UTC (permalink / raw)
To: bfd-cvs, gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=04d91c807eaf4395472409a53e2acd9ad89683f0
commit 04d91c807eaf4395472409a53e2acd9ad89683f0
Author: Nick Alcock <nick.alcock@oracle.com>
Date: Mon Mar 13 17:36:33 2023 +0000
libctf: fix a comment typo
ctf_dedup's intern() function does not return a dynamically allocated
string, so I just spent ten minutes auditing for obvious memory leaks
that couldn't actually happen. Update the comment to note what it
actually returns (a pointer into an atoms table: i.e. possibly not
a new string, and not so easily leakable).
libctf/
* ctf-dedup.c (intern): Update comment.
Diff:
---
libctf/ctf-dedup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libctf/ctf-dedup.c b/libctf/ctf-dedup.c
index 6297c45c84d..5fdddfd0b54 100644
--- a/libctf/ctf-dedup.c
+++ b/libctf/ctf-dedup.c
@@ -412,7 +412,7 @@ intern (ctf_dict_t *fp, char *atom)
/* Add an indication of the namespace to a type name in a way that is not valid
for C identifiers. Used to maintain hashes of type names to other things
while allowing for the four C namespaces (normal, struct, union, enum).
- Return a new dynamically-allocated string. */
+ Return a pointer into the cd_decorated_names atoms table. */
static const char *
ctf_decorate_type_name (ctf_dict_t *fp, const char *name, int kind)
{
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-03-24 14:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-24 14:08 [binutils-gdb] libctf: fix a comment typo Nick Alcock
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).