[binutils-gdb] gdb: remove unnecessary NULL checks for return value of value_from_register

[binutils-gdb] gdb: remove unnecessary NULL checks for return value of value_from_register

[Simon Marchi]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a332b7c7d0d604f4ea6e0ff4d9119e3ec73f6079

commit a332b7c7d0d604f4ea6e0ff4d9119e3ec73f6079
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Fri Jan 19 10:35:37 2024 -0500

    gdb: remove unnecessary NULL checks for return value of value_from_register
    
    value_from_register can't return nullptr, remove some NULL checks.
    
    Change-Id: Ia6b32b8f86e593c535e3678a89dffe5544eb7ab0
    Approved-By: Tom Tromey <tom@tromey.com>

Diff:
---
 gdb/findvar.c | 23 +++--------------------
 1 file changed, 3 insertions(+), 20 deletions(-)

diff --git a/gdb/findvar.c b/gdb/findvar.c
index d0bb3fd320e..37b859c2347 100644
--- a/gdb/findvar.c
+++ b/gdb/findvar.c
@@ -623,29 +623,12 @@ language_defn::read_var_value (struct symbol *var,
       {
 	int regno = SYMBOL_REGISTER_OPS (var)
 		      ->register_number (var, get_frame_arch (frame));
-	struct value *regval;
 
 	if (var->aclass () == LOC_REGPARM_ADDR)
-	  {
-	    regval = value_from_register (lookup_pointer_type (type),
-					  regno,
-					  frame);
-
-	    if (regval == NULL)
-	      error (_("Value of register variable not available for `%s'."),
-		     var->print_name ());
-
-	    addr = value_as_address (regval);
-	  }
+	  addr = value_as_address
+	   (value_from_register (lookup_pointer_type (type), regno, frame));
 	else
-	  {
-	    regval = value_from_register (type, regno, frame);
-
-	    if (regval == NULL)
-	      error (_("Value of register variable not available for `%s'."),
-		     var->print_name ());
-	    return regval;
-	  }
+	  return value_from_register (type, regno, frame);
       }
       break;