[binutils-gdb] Fix handling of DW_OP_GNU_push_tls_address

[binutils-gdb] Fix handling of DW_OP_GNU_push_tls_address

[Tom Tromey]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8f42049a8230baf871ccb66b4e607bd2ebcd99ab

commit 8f42049a8230baf871ccb66b4e607bd2ebcd99ab
Author: Tom Tromey <tromey@adacore.com>
Date:   Wed Jan 17 04:29:59 2024 -0700

    Fix handling of DW_OP_GNU_push_tls_address
    
    In one spot, DW_OP_GNU_push_tls_address is handled differently from
    DW_OP_form_tls_address.  However, I think they should always be
    treated identically.
    
    Approved-by: Kevin Buettner <kevinb@redhat.com>

Diff:
---
 gdb/dwarf2/loc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/dwarf2/loc.c b/gdb/dwarf2/loc.c
index 8a350b40258..1be5246e7a3 100644
--- a/gdb/dwarf2/loc.c
+++ b/gdb/dwarf2/loc.c
@@ -1954,12 +1954,12 @@ dwarf2_get_symbol_read_needs (gdb::array_view<const gdb_byte> expr,
 	case DW_OP_lt:
 	case DW_OP_gt:
 	case DW_OP_ne:
-	case DW_OP_GNU_push_tls_address:
 	case DW_OP_nop:
 	case DW_OP_GNU_uninit:
 	case DW_OP_push_object_address:
 	  break;
 
+	case DW_OP_GNU_push_tls_address:
 	case DW_OP_form_tls_address:
 	  if (symbol_needs <= SYMBOL_NEEDS_REGISTERS)
 	    symbol_needs = SYMBOL_NEEDS_REGISTERS;