public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Fix fail in gdb.dap/sources.exp
@ 2024-02-13 14:53 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2024-02-13 14:53 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a16034bf6417dc2259fef43fd5bcc2dd1dac562f

commit a16034bf6417dc2259fef43fd5bcc2dd1dac562f
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Feb 13 15:53:28 2024 +0100

    [gdb/testsuite] Fix fail in gdb.dap/sources.exp
    
    With test-case gdb.dap/sources.exp, I run into:
    ...
    {"request_seq": 4, "type": "response", "command": "source", \
      "success": false, "message": "notStopped", \
      "seq": 11}FAIL: gdb.dap/sources.exp: get source success
    ...
    
    The fail happens because the request races with the stopping at main as
    requested by:
    ...
    if {[dap_launch $testfile stop_at_main 1] == ""} {
    ...
    
    Fix this by waiting for the stop, in the same way that is done in other
    test-cases that use stop_at_main.
    
    Tested on x86_64-linux.
    
    Approved-By: Tom Tromey <tom@tromey.com>
    
    PR testsuite/31374
    https://sourceware.org/bugzilla/show_bug.cgi?id=31374

Diff:
---
 gdb/testsuite/gdb.dap/sources.exp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gdb/testsuite/gdb.dap/sources.exp b/gdb/testsuite/gdb.dap/sources.exp
index f601190d6f5..9b56337e5a8 100644
--- a/gdb/testsuite/gdb.dap/sources.exp
+++ b/gdb/testsuite/gdb.dap/sources.exp
@@ -46,6 +46,9 @@ if {$path == ""} {
 } else {
     pass "sources.c in loadedSources"
 
+    dap_wait_for_event_and_check "stopped at function breakpoint" stopped \
+	"body reason" breakpoint
+
     set obj [dap_check_request_and_response "get source" source \
 		 [format {o source [o path [s %s]] \
 			    sourceReference [i 0]} $path]]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-02-13 14:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-13 14:53 [binutils-gdb] [gdb/testsuite] Fix fail in gdb.dap/sources.exp Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).