public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] arc: Don't use multiline in arc-disassembler-options.exp test
@ 2024-02-13 21:49 Shahab Vahedi
0 siblings, 0 replies; only message in thread
From: Shahab Vahedi @ 2024-02-13 21:49 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fd07bcb16f1d0891b66931e0930a74355be12bb6
commit fd07bcb16f1d0891b66931e0930a74355be12bb6
Author: Yuriy Kolerov <kolerov93@gmail.com>
Date: Tue Feb 13 06:40:22 2024 +0000
arc: Don't use multiline in arc-disassembler-options.exp test
Breaking a TCL string to several lines leads to adding of extra
symbols to the resulting expect string. In turn, this leads to
failing of all test cases in gdb.arch/arc-disassembler-options.exp
testsuite. It's necessary to use multi_line function in such
cases.
Approved-By: Tom Tromey <tom@tromey.com>
Diff:
---
gdb/testsuite/gdb.arch/arc-disassembler-options.exp | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/gdb/testsuite/gdb.arch/arc-disassembler-options.exp b/gdb/testsuite/gdb.arch/arc-disassembler-options.exp
index 29c7e60b487..3a4c5234891 100644
--- a/gdb/testsuite/gdb.arch/arc-disassembler-options.exp
+++ b/gdb/testsuite/gdb.arch/arc-disassembler-options.exp
@@ -28,10 +28,11 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${objfile}" object {}] \
clean_restart ${objfile}
proc arc_disassemble_test { func insn mesg } {
- gdb_test "disassemble $func" \
- "Dump of assembler code for function $func:\r\n\
- \[^:\]+:\t$insn\r\nEnd of assembler dump\." \
- $mesg
+ set pass_re [multi_line \
+ "Dump of assembler code for function $func:" \
+ "\[^:\]+:\t$insn" \
+ "End of assembler dump\\."]
+ gdb_test "disassemble $func" $pass_re $mesg
}
# Verify defaults.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-02-13 21:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-13 21:49 [binutils-gdb] arc: Don't use multiline in arc-disassembler-options.exp test Shahab Vahedi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).