[binutils-gdb] Fix throw_winerror_with_name build error on x86-64 Cygwin

[binutils-gdb] Fix throw_winerror_with_name build error on x86-64 Cygwin

[Pedro Alves]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=593318f69b481f32f2a06093d2b9660b4fb77f24

commit 593318f69b481f32f2a06093d2b9660b4fb77f24
Author: Pedro Alves <pedro@palves.net>
Date:   Tue Feb 20 16:31:39 2024 +0000

    Fix throw_winerror_with_name build error on x86-64 Cygwin
    
    The GDB build currently fails on x86-64 Cygwin, with:
    
     src/gdbsupport/errors.cc: In function ‘void throw_winerror_with_name(const char*, ULONGEST)’:
     src/gdbsupport/errors.cc:152:12: error: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘ULONGEST’ {aka ‘long unsigned int’} [-Werror=format=]
       152 |   error (_("%s (error %d): %s"), string, err, strwinerror (err));
           |            ^
    
    Fix this by adding a cast.  While at it, the error codes are really a
    DWORD that results from a GetLastError() call, so I think unsigned is
    more appropriate.  That is also what strwinerror already does:
    
        sprintf (buf, "unknown win32 error (%u)", (unsigned) error);
    
    The cast is necessary on MinGW GDB as well, where ULONGEST is unsigned
    long long, but for some reason, I don't get a warning there.
    
    Approved-By: Tom Tromey <tom@tromey.com>
    Change-Id: I3f5faa779765fd8021abf58bb5f68d556b309d17

Diff:
---
 gdbsupport/errors.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdbsupport/errors.cc b/gdbsupport/errors.cc
index 8ac3ed0da79..cccdc5cafb2 100644
--- a/gdbsupport/errors.cc
+++ b/gdbsupport/errors.cc
@@ -149,7 +149,7 @@ strwinerror (ULONGEST error)
 void
 throw_winerror_with_name (const char *string, ULONGEST err)
 {
-  error (_("%s (error %d): %s"), string, err, strwinerror (err));
+  error (_("%s (error %u): %s"), string, (unsigned) err, strwinerror (err));
 }
 
 #endif /* USE_WIN32API */