public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Remove two unnecessary casts Date: Mon, 26 Feb 2024 20:55:39 +0000 (GMT) [thread overview] Message-ID: <20240226205539.CDE283858C98@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4c3b59d5ba864609049df054e117bf6417194d22 commit 4c3b59d5ba864609049df054e117bf6417194d22 Author: Tom Tromey <tromey@adacore.com> Date: Mon Feb 26 13:50:54 2024 -0700 Remove two unnecessary casts I noticed a spot in ada-lang.c where the return value of value_as_address was cast to CORE_ADDR -- a no-op cast. I searched and found another. This patch fixes both. Diff: --- gdb/ada-lang.c | 2 +- gdb/eval.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 3f398540010..1c26ebf7b30 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -10993,7 +10993,7 @@ ada_unop_ind_operation::evaluate (struct type *expect_type, arg1)); else return value_at_lazy (builtin_type (exp->gdbarch)->builtin_int, - (CORE_ADDR) value_as_address (arg1)); + value_as_address (arg1)); } if (ada_is_array_descriptor_type (type)) diff --git a/gdb/eval.c b/gdb/eval.c index 4c438f927c0..2759b46a5df 100644 --- a/gdb/eval.c +++ b/gdb/eval.c @@ -1685,7 +1685,7 @@ eval_op_ind (struct type *expect_type, struct expression *exp, BUILTIN_TYPE_LONGEST would seem to be a mistake. */ if (type->code () == TYPE_CODE_INT) return value_at_lazy (builtin_type (exp->gdbarch)->builtin_int, - (CORE_ADDR) value_as_address (arg1)); + value_as_address (arg1)); return value_ind (arg1); }
next reply other threads:[~2024-02-26 20:55 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-26 20:55 Tom Tromey [this message] -- strict thread matches above, loose matches on Subject: below -- 2022-12-13 16:00 Tom Tromey
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240226205539.CDE283858C98@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).