[binutils-gdb] Remove two unnecessary casts

[binutils-gdb] Remove two unnecessary casts

[Tom Tromey]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4c3b59d5ba864609049df054e117bf6417194d22

commit 4c3b59d5ba864609049df054e117bf6417194d22
Author: Tom Tromey <tromey@adacore.com>
Date:   Mon Feb 26 13:50:54 2024 -0700

    Remove two unnecessary casts
    
    I noticed a spot in ada-lang.c where the return value of
    value_as_address was cast to CORE_ADDR -- a no-op cast.  I searched
    and found another.  This patch fixes both.

Diff:
---
 gdb/ada-lang.c | 2 +-
 gdb/eval.c     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 3f398540010..1c26ebf7b30 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -10993,7 +10993,7 @@ ada_unop_ind_operation::evaluate (struct type *expect_type,
 					  arg1));
       else
 	return value_at_lazy (builtin_type (exp->gdbarch)->builtin_int,
-			      (CORE_ADDR) value_as_address (arg1));
+			      value_as_address (arg1));
     }
 
   if (ada_is_array_descriptor_type (type))
diff --git a/gdb/eval.c b/gdb/eval.c
index 4c438f927c0..2759b46a5df 100644
--- a/gdb/eval.c
+++ b/gdb/eval.c
@@ -1685,7 +1685,7 @@ eval_op_ind (struct type *expect_type, struct expression *exp,
      BUILTIN_TYPE_LONGEST would seem to be a mistake.  */
   if (type->code () == TYPE_CODE_INT)
     return value_at_lazy (builtin_type (exp->gdbarch)->builtin_int,
-			  (CORE_ADDR) value_as_address (arg1));
+			  value_as_address (arg1));
   return value_ind (arg1);
 }

[binutils-gdb] Remove two unnecessary casts

[Tom Tromey]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=41daaea2ccaef06fdb648e7f2a3095d8feac2aa5

commit 41daaea2ccaef06fdb648e7f2a3095d8feac2aa5
Author: Tom Tromey <tromey@adacore.com>
Date:   Tue Dec 13 08:58:50 2022 -0700

    Remove two unnecessary casts
    
    A couple of calls to parse_probe_linespec had an unnecessary cast.  I
    suspect this cast was never needed, but once commands were changed to
    take a 'const' argument, they became completely obsolete.  Tested by
    rebuilding.

Diff:
---
 gdb/probe.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/probe.c b/gdb/probe.c
index ec8845219fa..4193f9f936b 100644
--- a/gdb/probe.c
+++ b/gdb/probe.c
@@ -617,7 +617,7 @@ enable_probes_command (const char *arg, int from_tty)
 {
   std::string provider, probe_name, objname;
 
-  parse_probe_linespec ((const char *) arg, &provider, &probe_name, &objname);
+  parse_probe_linespec (arg, &provider, &probe_name, &objname);
 
   std::vector<bound_probe> probes
     = collect_probes (objname, provider, probe_name, &any_static_probe_ops);
@@ -652,7 +652,7 @@ disable_probes_command (const char *arg, int from_tty)
 {
   std::string provider, probe_name, objname;
 
-  parse_probe_linespec ((const char *) arg, &provider, &probe_name, &objname);
+  parse_probe_linespec (arg, &provider, &probe_name, &objname);
 
   std::vector<bound_probe> probes
     = collect_probes (objname, provider, probe_name, &any_static_probe_ops);