[binutils-gdb] gdb: remove some dead code from completer.c

[binutils-gdb] gdb: remove some dead code from completer.c

[Andrew Burgess]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c8adaf3dd31e154afc6577d93ea3db675c11eb97

commit c8adaf3dd31e154afc6577d93ea3db675c11eb97
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Tue Jan 16 16:08:12 2024 +0000

    gdb: remove some dead code from completer.c
    
    In completer.c there is some code that is surrounded with '#if 0',
    this code:
    
      #if 0
        /* There is no way to do this just long enough to affect quote
           inserting without also affecting the next completion.  This
           should be fixed in readline.  FIXME.  */
        /* Ensure that readline does the right thing
           with respect to inserting quotes.  */
        rl_completer_word_break_characters = "";
      #endif
    
    This code, in some form, and always defined out, has been around since
    the original import of GDB.  Though the comment hints at what the
    problem might be, it's not really clear what the issue is.  And
    completion within GDB has moved on a long way since this code was
    written ... but not used.
    
    I'm proposing that we just remove this code.
    
    If/when a problem comes up then we can look at how to solve it.  Maybe
    this code would be the answer ... but also, I suspect, given all the
    changes ... maybe not.  I'm not sure carrying around this code for
    another 20+ years adds much value.
    
    There should be no user visible changes after this commit.

Diff:
---
 gdb/completer.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/gdb/completer.c b/gdb/completer.c
index cefac605a33..330c39598c5 100644
--- a/gdb/completer.c
+++ b/gdb/completer.c
@@ -241,14 +241,6 @@ filename_completer (struct cmd_list_element *ignore,
       tracker.add_completion
 	(make_completion_match_str (std::move (p_rl), text, word));
     }
-#if 0
-  /* There is no way to do this just long enough to affect quote
-     inserting without also affecting the next completion.  This
-     should be fixed in readline.  FIXME.  */
-  /* Ensure that readline does the right thing
-     with respect to inserting quotes.  */
-  rl_completer_word_break_characters = "";
-#endif
 }
 
 /* The corresponding completer_handle_brkchars