public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Add missing include in gdb.base/rtld-step.exp
@ 2024-03-28  5:52 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2024-03-28  5:52 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6ccf769a1790b90a85e0b4912a42117eb7c1e108

commit 6ccf769a1790b90a85e0b4912a42117eb7c1e108
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Mar 28 06:51:59 2024 +0100

    [gdb/testsuite] Add missing include in gdb.base/rtld-step.exp
    
    On fedora rawhide, with test-case gdb.base/rtld-step.exp I get:
    ...
    static-pie-static-libc.c: In function '_start':^M
    static-pie-static-libc.c:1:22: error: \
      implicit declaration of function '_exit' [-Wimplicit-function-declaration]^M
        1 | void _start (void) { _exit (0); }^M
          |                      ^~~~~^M
    compiler exited with status 1
      ...
    UNTESTED: gdb.base/rtld-step.exp: failed to compile \
      (-static-pie not supported or static libc missing)
    ...
    
    Fix this by adding the missing include.
    
    Tested on aarch64-linux.
    
    Approved-by: Kevin Buettner <kevinb@redhat.com>

Diff:
---
 gdb/testsuite/gdb.base/rtld-step.exp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.base/rtld-step.exp b/gdb/testsuite/gdb.base/rtld-step.exp
index 53725833aa1..198542886cc 100644
--- a/gdb/testsuite/gdb.base/rtld-step.exp
+++ b/gdb/testsuite/gdb.base/rtld-step.exp
@@ -86,7 +86,10 @@ set rtld_flags [list debug additional_flags=[list -static-pie -fPIE \
 						  -nostdlib -static -lc]]
 
 if { ![gdb_can_simple_compile static-pie-static-libc \
-	   "void _start (void) { _exit (0); }" \
+	   {
+	       #include <unistd.h>
+	       void _start (void) { _exit (0); }
+	   } \
 	   executable $rtld_flags] } {
     set reason "-static-pie not supported or static libc missing"
     untested "failed to compile ($reason)"

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-03-28  5:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-28  5:52 [binutils-gdb] [gdb/testsuite] Add missing include in gdb.base/rtld-step.exp Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).