public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Add missing include in gdb.base/ctf-ptype.c
@ 2024-04-02 14:22 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2024-04-02 14:22 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=374c1cbbf062e1d35cd285c583a99268a3e1de6c

commit 374c1cbbf062e1d35cd285c583a99268a3e1de6c
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Apr 2 16:22:46 2024 +0200

    [gdb/testsuite] Add missing include in gdb.base/ctf-ptype.c
    
    On fedora rawhide, when running test-case gdb.base/ctf-ptype.exp, I get:
    ...
    gdb compile failed, ctf-ptype.c: In function 'main':
    ctf-ptype.c:242:29: error: implicit declaration of function 'malloc' \
      [-Wimplicit-function-declaration]
      242 |   v_char_pointer = (char *) malloc (1);
          |                             ^~~~~~
    ctf-ptype.c:1:1: note: include '<stdlib.h>' or provide a declaration of 'malloc'
      +++ |+#include <stdlib.h>
        1 | /* This test program is part of GDB, the GNU debugger.
    ...
    
    Fix this by adding the missing include.
    
    Tested on aarch64-linux.

Diff:
---
 gdb/testsuite/gdb.base/ctf-ptype.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.base/ctf-ptype.c b/gdb/testsuite/gdb.base/ctf-ptype.c
index 4d2df33c53c..ca347893349 100644
--- a/gdb/testsuite/gdb.base/ctf-ptype.c
+++ b/gdb/testsuite/gdb.base/ctf-ptype.c
@@ -24,6 +24,8 @@
  *	First the basic C types.
  */
 
+#include <stdlib.h>
+
 #if !defined (__STDC__) && !defined (_AIX)
 #define signed  /**/
 #endif
@@ -234,9 +236,6 @@ func_type v_func_type;
 
 int main ()
 {
-  /* Ensure that malloc is a pointer type; avoid use of "void" and any include files. */
-/*  extern char *malloc();*/
-
   /* Some of the tests in ptype.exp require invoking malloc, so make
      sure it is linked in to this program.  */
   v_char_pointer = (char *) malloc (1);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-04-02 14:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-02 14:22 [binutils-gdb] [gdb/testsuite] Add missing include in gdb.base/ctf-ptype.c Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).