public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Do not use bare "except"
@ 2024-04-02 17:10 Tom Tromey
0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2024-04-02 17:10 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e2238b2e2061cffd2b7ae2894747205a56d2f775
commit e2238b2e2061cffd2b7ae2894747205a56d2f775
Author: Tom Tromey <tromey@adacore.com>
Date: Tue Mar 19 11:11:05 2024 -0600
Do not use bare "except"
flake8 warns about a bare "except". The docs point out that this will
also catch KeyboardInterrupt and SystemExit exceptions, which is
normally undesirable. Using "except Exception" catches everything
reasonable, so this patch makes this change.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Diff:
---
gdb/python/lib/gdb/__init__.py | 2 +-
gdb/python/lib/gdb/styling.py | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gdb/python/lib/gdb/__init__.py b/gdb/python/lib/gdb/__init__.py
index 611d725af58..aae0d3680aa 100644
--- a/gdb/python/lib/gdb/__init__.py
+++ b/gdb/python/lib/gdb/__init__.py
@@ -159,7 +159,7 @@ def _auto_load_packages():
reload(__import__(modname))
else:
__import__(modname)
- except:
+ except Exception:
sys.stderr.write(traceback.format_exc() + "\n")
diff --git a/gdb/python/lib/gdb/styling.py b/gdb/python/lib/gdb/styling.py
index 704c9926c29..8e5d64f15d9 100644
--- a/gdb/python/lib/gdb/styling.py
+++ b/gdb/python/lib/gdb/styling.py
@@ -39,7 +39,7 @@ try:
return highlight(contents, lexer, formatter).encode(
gdb.host_charset(), "backslashreplace"
)
- except:
+ except Exception:
return None
class HandleNasmComments(TokenMergeFilter):
@@ -70,7 +70,7 @@ try:
flavor = gdb.parameter("disassembly-flavor")
if flavor == "intel" and gdbarch.name()[:4] == "i386":
lexer_type = "nasm"
- except:
+ except Exception:
# If GDB is built without i386 support then attempting to fetch
# the 'disassembly-flavor' parameter will throw an error, which we
# ignore.
@@ -89,7 +89,7 @@ try:
lexer = __get_asm_lexer(gdbarch)
formatter = get_formatter()
return highlight(content, lexer, formatter).rstrip().encode()
- except:
+ except Exception:
return content
except ImportError:
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-02 17:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-02 17:10 [binutils-gdb] Do not use bare "except" Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).