public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb/testsuite: Use default gdb_expect timeout in runto
@ 2024-04-22 16:13 Thiago Bauermann
  0 siblings, 0 replies; only message in thread
From: Thiago Bauermann @ 2024-04-22 16:13 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fdaa4939e5024ea809c0d4d1aa6043a60b37d9b5

commit fdaa4939e5024ea809c0d4d1aa6043a60b37d9b5
Author: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Date:   Thu Apr 4 14:22:22 2024 -0300

    gdb/testsuite: Use default gdb_expect timeout in runto
    
    runto uses a hard-coded timeout of 30s in its invocation of gdb_expect.
    This is normally fine, but for very a slow system (e.g., an emulator) it
    may not be enough time for GDB to reach the intended breakpoint.
    
    gdb_expect can obtain a timeout value from user-configurable variables
    when it's not given one explicitly, so use that mechanism instead since
    the user will have already adjusted the timeout variable to account for
    the slow system.
    
    Approved-By: Tom Tromey <tom@tromey.com>

Diff:
---
 gdb/testsuite/lib/gdb.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index ddee928d510..cbd37fd3094 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -768,7 +768,7 @@ proc runto { linespec args } {
     
     # the "at foo.c:36" output we get with -g.
     # the "in func" output we get without -g.
-    gdb_expect 30 {
+    gdb_expect {
 	-re "(?:Break|Temporary break).* at .*:$decimal.*$gdb_prompt $" {
 	    if { $print_pass } {
 		pass $test_name

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-04-22 16:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-22 16:13 [binutils-gdb] gdb/testsuite: Use default gdb_expect timeout in runto Thiago Bauermann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).