public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb: include extract-store-integer.h in charset.c when PHONY_ICONV
@ 2024-04-24  3:02 Simon Marchi
  0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2024-04-24  3:02 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1a7f925ea20c82fc9899f41d21df8e21dcae3169

commit 1a7f925ea20c82fc9899f41d21df8e21dcae3169
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Wed Apr 24 02:52:00 2024 +0000

    gdb: include extract-store-integer.h in charset.c when PHONY_ICONV
    
    When building on a system where "phony iconv" is used (NetBSD in this
    case, not sure why), I get:
    
          CXX    charset.o
        /home/smarchi/src/binutils-gdb/gdb/charset.c: In function 'size_t phony_iconv(int, const char**, size_t*, char**, size_t*)':
        /home/smarchi/src/binutils-gdb/gdb/charset.c:140:8: error: 'extract_unsigned_integer' was not declared in this scope
              = extract_unsigned_integer ((const gdb_byte *)*inbuf, 4, endian);
                ^~~~~~~~~~~~~~~~~~~~~~~~
        /home/smarchi/src/binutils-gdb/gdb/charset.c:140:8: note: suggested alternative: 'btrace_insn_number'
              = extract_unsigned_integer ((const gdb_byte *)*inbuf, 4, endian);
                ^~~~~~~~~~~~~~~~~~~~~~~~
                btrace_insn_number
    
    Add the necessary include.
    
    Change-Id: I10b967584645961c86167a8395d88929a42bef03

Diff:
---
 gdb/charset.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdb/charset.c b/gdb/charset.c
index 4c1debef614..17a9ca81b2e 100644
--- a/gdb/charset.c
+++ b/gdb/charset.c
@@ -71,6 +71,8 @@
 \f
 #ifdef PHONY_ICONV
 
+#include "extract-store-integer.h"
+
 /* Provide a phony iconv that does as little as possible.  Also,
    arrange for there to be a single available character set.  */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-04-24  3:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-24  3:02 [binutils-gdb] gdb: include extract-store-integer.h in charset.c when PHONY_ICONV Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).