public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Fix end_sequence addresses for dw2-lines.exp
@ 2024-04-25 22:05 Carl Love
  0 siblings, 0 replies; only message in thread
From: Carl Love @ 2024-04-25 22:05 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a99345fcd086f3057d0ca4970908a0ac2e00b06a

commit a99345fcd086f3057d0ca4970908a0ac2e00b06a
Author: Carl Love <cel@linux.ibm.com>
Date:   Wed Apr 24 14:14:10 2024 -0400

    Fix end_sequence addresses for dw2-lines.exp
    
    The patch:
    
      From f0d556d14b1d1c3f8e2f9c13b08adca22e1b8c9c Mon Sep 17 00:00:00 2001
      From: Tom de Vries <tdevries@suse.de>
      Date: Wed, 17 Apr 2024 12:55:00 +0200
      Subject: [PATCH] [gdb/testsuite] Fix end_sequence addresses
    
      I noticed in test-case gdb.reverse/map-to-same-line.exp, that the end of main:
      ...
      00000000004102c4 <end_of_sequence>:
        4102c4:       52800000        mov     w0, #0x0                        // #0
       4102c8:       9100c3ff        add     sp, sp, #0x30
        4102cc:       d65f03c0        ret
      ...
      is not described by the line table:
      ...
    
      <snip>
    
    The regression failure on PowerPC is due to the change in file
    dw2-lines.exp,
    
    -               DW_LNE_set_address bar_label_5
    +               DW_LNE_set_address "$main_start + $main_len"
    
    The label bar_label_5 is in function bar, not function main.  The new
    set address should have been $bar_start + $bar_len.

Diff:
---
 gdb/testsuite/gdb.dwarf2/dw2-lines.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.dwarf2/dw2-lines.exp b/gdb/testsuite/gdb.dwarf2/dw2-lines.exp
index 85d5e9c8afb..af5b6b71768 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-lines.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-lines.exp
@@ -104,7 +104,7 @@ proc test_1 { _cv _cdw64 _lv _ldw64 {_string_form ""}} {
 		line [line_for bar_label_4]
 		DW_LNS_copy
 
-		DW_LNE_set_address "$main_start + $main_len"
+		DW_LNE_set_address "$bar_start + $bar_len"
 		DW_LNE_end_sequence
 	    }
 	}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-04-25 22:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-25 22:05 [binutils-gdb] Fix end_sequence addresses for dw2-lines.exp Carl Love

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).