public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Move gpu-parallel.lock to cache dir
@ 2024-05-04 8:41 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2024-05-04 8:41 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a0a6e110198c4f7fb4b5baa1f8d158ebf225f7e2
commit a0a6e110198c4f7fb4b5baa1f8d158ebf225f7e2
Author: Tom de Vries <tdevries@suse.de>
Date: Sat May 4 10:41:09 2024 +0200
[gdb/testsuite] Move gpu-parallel.lock to cache dir
The lock directory returned by lock_dir is currently $objdir.
It seems possible to leave a stale lock file that blocks progress in a
following run.
Fix this by using a directory that is guaranteed to be initially empty when
using GDB_PARALLEL, like temp or cache.
In gdb/testsuite/README I found:
...
cache in particular is used to share data across invocations of runtest
...
which seems appropriate, so let's use cache for this.
Tested on aarch64-linux.
Approved-By: Tom Tromey <tom@tromey.com>
Diff:
---
gdb/testsuite/lib/gdb-utils.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/lib/gdb-utils.exp b/gdb/testsuite/lib/gdb-utils.exp
index c0b96d3c2bf..1f30d807ff0 100644
--- a/gdb/testsuite/lib/gdb-utils.exp
+++ b/gdb/testsuite/lib/gdb-utils.exp
@@ -180,7 +180,7 @@ proc lock_file_release {info} {
# Return directory where we keep lock files.
proc lock_dir {} {
- return $objdir
+ return [make_gdb_parallel_path cache]
}
# Run body under lock LOCK_FILE.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-05-04 8:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-04 8:41 [binutils-gdb] [gdb/testsuite] Move gpu-parallel.lock to cache dir Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).