public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdbserver/ipa/x86: remove unneeded declarations
@ 2024-05-07 15:04 Andrew Burgess
  0 siblings, 0 replies; only message in thread
From: Andrew Burgess @ 2024-05-07 15:04 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3f1438a5b2ef4a6b2bd3cc0600033362c43de7b3

commit 3f1438a5b2ef4a6b2bd3cc0600033362c43de7b3
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Tue Apr 2 13:42:37 2024 +0100

    gdbserver/ipa/x86: remove unneeded declarations
    
    Spotted some declarations in gdbserver/linux-amd64-ipa.cc that are no
    longer needed.  These are:
    
      1. 'init_registers_amd64_linux' - the comment claims this function
      is auto generated, but I don't believe that this is still the case.
      Also the function is not used in this file,
    
      2. 'tdesc_amd64_linux' - this variable doesn't seem to exist any
      more, I suspect this was renamed to 'tdesc_amd64_linux_no_xml', but
      neither are used in this file, so lets remove the declaration.
    
    The amd64 in-process-agent still builds fine after this commit.
    
    There should be no user visible changes after this commit.
    
    Approved-By: Felix Willgerodt <felix.willgerodt@intel.com>

Diff:
---
 gdbserver/linux-amd64-ipa.cc | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/gdbserver/linux-amd64-ipa.cc b/gdbserver/linux-amd64-ipa.cc
index 13c8a5bb360..a6346750f49 100644
--- a/gdbserver/linux-amd64-ipa.cc
+++ b/gdbserver/linux-amd64-ipa.cc
@@ -23,10 +23,6 @@
 #include "linux-x86-tdesc.h"
 #include "gdbsupport/x86-xstate.h"
 
-/* Defined in auto-generated file amd64-linux.c.  */
-void init_registers_amd64_linux (void);
-extern const struct target_desc *tdesc_amd64_linux;
-
 /* fast tracepoints collect registers.  */
 
 #define FT_CR_RIP 0

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-05-07 15:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-07 15:04 [binutils-gdb] gdbserver/ipa/x86: remove unneeded declarations Andrew Burgess

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).