Re: [PATCH] internal_error: remove need to pass __FILE__/__LINE__

[Simon Marchi <simark@simark.ca>]

On 10/18/22 08:34, Bruno Larsen via Gdb-patches wrote:
> 
> On 17/10/2022 21:45, Simon Marchi via Gdb-patches wrote:
>> Heh, I forgot to look at the code.  It all looks good, except black
>> reformats gdbarch.py for me here.  With that fixed you can add my
>> Reviewed-By or Approved-By (not sure which one we use when someone who
>> can approve a patch reviews the patch of someone else who can approve).
> 
> I would suggest Pedro use the Approved-by tag. Preferably the approver of the patch should be different to the submitter.
> 
> My thought process for someone who can approve using a reviewed-by tag is if you don't know enough for the area of code but you did look at the patch and saw nothing wrong with it. About the same situation when you'd say "this patch looks good to me but I'd defer to XXX, who knows this better" before we started using tags.

Thanks, that makes sense.

In the case of reviewing Pedro's patches, we would need a tag to say "It
looks good, I don't think I understand it all, but given that Pedro
wrote the patch, it's most likely correct" :).

Simon