Re: [PATCH] internal_error: remove need to pass __FILE__/__LINE__

[Simon Marchi <simark@simark.ca>]

On 2022-10-17 15:37, Pedro Alves wrote:
> On 2022-10-17 8:27 p.m., Simon Marchi wrote:
> 
>>> Most probably.  I prefer keeping internal_error for it being more pervasive
>>> and older.  gdb_assert_not_reached is a more recent addition.
>>
>> Fine with me.
>>
>>>> The only difference is that gdb_assert_not_reached includes the
>>>> function name, but I don't think it's an important difference.  I think
>>>> we could switch to a single one that does include the function name.
>>>
>>> I don't think it needs to be in this patch, though?
>>>
>>> This one is just making internal_error more convenient to call.  We can
>>> always look at doing something to its internals separately.
>>
>> Sure, it's just an idea for eventually.
> 
> Cool, thanks.  
> 
> I guess I am not sure whether your earlier comment meant that you're OK
> with the patch itself (rather than the idea), though.  :-)

Heh, I forgot to look at the code.  It all looks good, except black
reformats gdbarch.py for me here.  With that fixed you can add my
Reviewed-By or Approved-By (not sure which one we use when someone who
can approve a patch reviews the patch of someone else who can approve).

Another though for later: like gdb_assert_not_reached, we could move the
gettext translation call, `_(...)`, into the internal_error macro.  That
would make the callers a bit simpler (although IMO these strings don't
really need translation, since they are meant for GDB developers).

Simon