Re: [PATCH 1/6] Fix "ptype INTERNAL_FUNC" (PR gdb/30105)

[Pedro Alves <pedro@palves.net>]

On 2023-02-14 3:26 p.m., Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
> 
> Pedro> That comment quoted above says that gcc -Wall will reveal any types
> Pedro> that haven't been handled, but that's not actually true, at least with
> Pedro> modern GCCs.  You would need to enable -Wswitch-enum for that, which
> Pedro> we don't.
> 
> We could do it for selected switches using a pragma, if we wanted.

Yeah, that is actually what I had done locally, to check which enums we
weren't handling, with the patch below.

> (What would be cool is an attribute to apply to the switch so we didn't
> have to wrap the whole thing.)

Yeah!  I have the vague impression of once seeing that clang has something
like that, but I may be wrong.

> 
> I tried enabling it globally but it has a lot of noise, and adding
> "default" all over defeats the purpose of the flag.

*nod*

From 715b0e7d83f02fe2e6356ea297d81dd6e3105858 Mon Sep 17 00:00:00 2001
From: Pedro Alves <pedro@palves.net>
Date: Thu, 9 Feb 2023 21:26:50 +0000
Subject: [PATCH] -Wswitch-enum

Change-Id: I09d8bab56abe241e21564812e910452a68752b1e
---
 gdb/c-typeprint.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c
index dca96231117..3966961f149 100644
--- a/gdb/c-typeprint.c
+++ b/gdb/c-typeprint.c
@@ -372,6 +372,9 @@ c_type_print_varspec_prefix (struct type *type,
 
   QUIT;
 
+DIAGNOSTIC_PUSH
+DIAGNOSTIC_ERROR ("-Wswitch-enum")
+
   switch (type->code ())
     {
     case TYPE_CODE_PTR:
@@ -467,6 +470,8 @@ c_type_print_varspec_prefix (struct type *type,
       error (_("type not handled in c_type_print_varspec_prefix()"));
       break;
     }
+
+DIAGNOSTIC_POP
 }
 
 /* Print out "const" and "volatile" attributes,
@@ -763,6 +768,9 @@ c_type_print_varspec_suffix (struct type *type,
 
   QUIT;
 
+DIAGNOSTIC_PUSH
+DIAGNOSTIC_ERROR ("-Wswitch-enum")
+
   switch (type->code ())
     {
     case TYPE_CODE_ARRAY:
@@ -848,6 +856,9 @@ c_type_print_varspec_suffix (struct type *type,
       error (_("type not handled in c_type_print_varspec_suffix()"));
       break;
     }
+
+DIAGNOSTIC_POP
+
 }
 
 /* A helper for c_type_print_base that displays template

base-commit: b885aea1bb987435929b4298982ac6fc27f69403
prerequisite-patch-id: 8137bd248a83bbcb2cacfb0250eef1994eafaeac
prerequisite-patch-id: 78b3c4f199e7af4170c5fc713bd88fd4ac62dc36
-- 
2.36.0