From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 6/6] Don't throw quit while handling inferior events, part II
Date: Wed, 15 Feb 2023 21:24:00 +0000 [thread overview]
Message-ID: <23a2ad58-6a57-7bd1-59e5-9e375744101b@palves.net> (raw)
In-Reply-To: <395ffc36-d9a2-d809-d122-1701ef787cae@palves.net>
On 2023-02-15 9:16 p.m., Pedro Alves wrote:
> On 2023-02-14 3:54 p.m., Tom Tromey wrote:
>>>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
>>
>> Pedro> I noticed that if Ctrl-C was typed just while GDB is evaluating a
>> Pedro> breakpoint condition in the background, and GDB ends up reaching out
>> Pedro> to the Python interpreter, then the breakpoint condition would still
>> Pedro> fail, like:
>>
>> Pedro> The fix is to disable cooperative SIGINT handling while handling
>> Pedro> inferior events, so that SIGINT is saved in the global quit flag, and
>> Pedro> not in the extension language, while handling an event.
>>
>> I wonder if there's an open PR about this.
>> It sounds vaguely familiar.
>>
>
> Hmm, I didn't see it the first time, but looking again, this one:
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=26266
>
> I think ends up fixed by the series, since normal_stop is called from
> within fetch_inferior_events, while the quit_handler and cooperative
> sigint handling are hijacked.
>
> I won't close that PR as in the linked discussion Andrew suggested
> a good idea for a testcase.
>
Eh, and this one, in this comment:
https://sourceware.org/bugzilla/show_bug.cgi?id=15297#c6
... my older self touches on the problem that this patch fixes. I had
completely forgotten that.
prev parent reply other threads:[~2023-02-15 21:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 23:35 [PATCH 0/6] Don't throw quit while handling inferior events Pedro Alves
2023-02-10 23:35 ` [PATCH 1/6] Fix "ptype INTERNAL_FUNC" (PR gdb/30105) Pedro Alves
2023-02-13 16:02 ` Andrew Burgess
2023-02-14 15:26 ` Tom Tromey
2023-02-15 21:10 ` Pedro Alves
2023-02-15 22:04 ` Tom Tromey
2023-02-10 23:36 ` [PATCH 2/6] Make "ptype INTERNAL_FUNCTION" in Ada print like other languages Pedro Alves
2023-02-13 16:02 ` Andrew Burgess
2023-02-14 15:30 ` Tom Tromey
2023-02-15 13:38 ` Pedro Alves
2023-02-15 15:13 ` Pedro Alves
2023-02-15 16:56 ` Tom Tromey
2023-02-15 21:04 ` [PATCH] Move TYPE_CODE_INTERNAL_FUNCTION type printing to common code (was: Re: [PATCH 2/6] Make "ptype INTERNAL_FUNCTION" in Ada print like other languages) Pedro Alves
2023-02-20 15:28 ` Andrew Burgess
2023-02-10 23:36 ` [PATCH 3/6] Add new "$_shell(CMD)" internal function Pedro Alves
2023-02-11 8:02 ` Eli Zaretskii
2023-02-13 15:11 ` Pedro Alves
2023-02-13 15:36 ` Eli Zaretskii
2023-02-13 16:47 ` [PATCH] gdb/manual: Move @findex entries (was: Re: [PATCH 3/6] Add new "$_shell(CMD)" internal function) Pedro Alves
2023-02-13 17:00 ` Eli Zaretskii
2023-02-13 17:27 ` [PATCH 3/6] Add new "$_shell(CMD)" internal function Pedro Alves
2023-02-13 18:41 ` Eli Zaretskii
2023-02-14 15:38 ` Tom Tromey
2023-02-10 23:36 ` [PATCH 4/6] Don't throw quit while handling inferior events Pedro Alves
2023-02-14 15:50 ` Tom Tromey
2023-02-10 23:36 ` [PATCH 5/6] GC get_active_ext_lang Pedro Alves
2023-02-14 15:39 ` Tom Tromey
2023-02-10 23:36 ` [PATCH 6/6] Don't throw quit while handling inferior events, part II Pedro Alves
2023-02-14 15:54 ` Tom Tromey
2023-02-15 21:16 ` Pedro Alves
2023-02-15 21:24 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23a2ad58-6a57-7bd1-59e5-9e375744101b@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).