Re: [PATCH 2/2] [gdb] Fix rethrow exception slicing in insert_bp_location

[Tom de Vries <tdevries@suse.de>]

On 10/24/22 18:36, Pedro Alves wrote:
> On 2022-10-24 9:49 a.m., Tom de Vries via Gdb-patches wrote:
> 
>> +#define RETHROW_ON_TARGET_CLOSE_ERROR(E)				\
>> +  do									\
>> +    {									\
>> +      if ((E).reason != 0)						\
>> +	{								\
>> +	  /* Can't set the breakpoint.  */				\
>> +									\
>> +	  if ((E).error == TARGET_CLOSE_ERROR)				\
>> +	    /* If the target has closed then it will have deleted any	\
>> +	       breakpoints inserted within the target inferior, as a	\
>> +	       result any further attempts to interact with the		\
>> +	       breakpoint objects is not possible.  Just rethrow the	\
>> +	       error.  Don't use E to rethrow, to prevent object	\
>> +	       slicing of the exception.  */				\
>> +	    throw;							\
>> +	}								\
>> +    } while (0)
> 
> Is there a reason this is a macro instead of a function?

yes, the throw without expression.

Do you know of a way to do this using a function?

Thanks,
- Tom