From: Pedro Alves <pedro@palves.net>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] [gdb] Fix rethrow exception slicing in insert_bp_location
Date: Tue, 25 Oct 2022 10:26:49 +0100 [thread overview]
Message-ID: <ca56e83c-f9f3-249a-bf8e-b800e8203341@palves.net> (raw)
In-Reply-To: <546f7fe4-7caa-4b78-bfd5-19480d60420e@suse.de>
On 2022-10-25 8:14 a.m., Tom de Vries wrote:
> On 10/24/22 18:51, Pedro Alves wrote:
>> On 2022-10-24 5:43 p.m., Tom de Vries wrote:
>>> On 10/24/22 18:36, Pedro Alves wrote:
>>>> On 2022-10-24 9:49 a.m., Tom de Vries via Gdb-patches wrote:
>>>> Is there a reason this is a macro instead of a function?
>>>
>>> yes, the throw without expression.
>>>
>>> Do you know of a way to do this using a function?
>>
>> WDYM? I believe it should Just Work. E.g.:
...
> Hmm, it does indeed, I didn't realize this was possible.
>
> Fixed in attached patch.
>
> Any further comments?
Nope, looks fine.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2022-10-25 9:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 8:49 [PATCH 0/2] [gdb] Fix rethrow exception slicing Tom de Vries
2022-10-24 8:49 ` [PATCH 1/2] [gdb] Fix rethrow exception slicing in pretty_print_insn Tom de Vries
2022-10-24 8:49 ` [PATCH 2/2] [gdb] Fix rethrow exception slicing in insert_bp_location Tom de Vries
2022-10-24 16:36 ` Pedro Alves
2022-10-24 16:43 ` Tom de Vries
2022-10-24 16:48 ` Simon Marchi
2022-10-25 7:08 ` Tom de Vries
2022-10-24 16:51 ` Pedro Alves
2022-10-25 7:14 ` Tom de Vries
2022-10-25 9:26 ` Pedro Alves [this message]
2022-10-24 11:20 ` [PATCH 0/2] [gdb] Fix rethrow exception slicing Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca56e83c-f9f3-249a-bf8e-b800e8203341@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).