From: Richard Bunt <richard.bunt@linaro.org>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/testsuite: make gdb_get_worker_threads reads default number of threads
Date: Wed, 6 Dec 2023 16:33:49 +0000 [thread overview]
Message-ID: <040368e0-ec82-4800-ab5f-49811353d7b4@linaro.org> (raw)
In-Reply-To: <bb85951d-e336-83a0-bd0d-41ef40f0e919@redhat.com>
On 06/12/2023 15:44, Guinevere Larsen wrote:
> On 06/12/2023 16:39, Tom Tromey wrote:
>>>>>>> "Guinevere" == Guinevere Larsen <blarsen@redhat.com> writes:
>> Guinevere> When a test in the testsuite attempts to collect the amount
>> of worker
>> Guinevere> threads GDB is able to use, it calls the proc
>> gdb_get_worker_threads,
>> Guinevere> which could understand if the number was unlimited or when
>> it had been
>> Guinevere> explicitly defined to a number, but it was unable to
>> understand the
>> Guinevere> default message. That lead to the following TCL error in some
>> Guinevere> situations:
>>
>> Thanks for the patch.. I think this was fixed yesterday by:
>>
>> commit 66e00622a89a0fd1c37539a72c6cdd7c6bd334e7
>> Author: Richard Bunt <richard.bunt@linaro.org>
>> Date: Tue Dec 5 09:54:12 2023 +0000
>>
>> gdb/testsuite: Update worker thread show assertion
>>
>> Tom
>>
> Yes, You approved that fix just a bit before I sent this one. Either
> way, I'm glad its fixed :)
>
> (i didn't push this one because of that)
>
Sorry for the noise on this one. My internal CI marked this test as
UNSUPPORTED so I missed it. I will improve my internal set up.
prev parent reply other threads:[~2023-12-06 16:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 15:26 Guinevere Larsen
2023-12-05 21:45 ` Keith Seitz
2023-12-06 16:22 ` Andrew Burgess
2023-12-06 16:35 ` Tom de Vries
2023-12-06 15:39 ` Tom Tromey
2023-12-06 15:44 ` Guinevere Larsen
2023-12-06 16:33 ` Richard Bunt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=040368e0-ec82-4800-ab5f-49811353d7b4@linaro.org \
--to=richard.bunt@linaro.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).