Re: [PATCH] gdb/testsuite: make gdb_get_worker_threads reads default number of threads

[Tom de Vries <tdevries@suse.de>]

On 12/6/23 17:22, Andrew Burgess wrote:
> Keith Seitz <keiths@redhat.com> writes:
> 
>> Hi,
>>
>> On 12/5/23 07:26, Guinevere Larsen wrote:
>>
>>> One such example is the current buildbot instance (at least the clang
>>> version). This commit adds a new clause to the gdb_get_worker_threads
>>> that detects the default worker thread message.
>>> ---
>>>    gdb/testsuite/lib/gdb.exp | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
>>> index d0990dcfe0e..148476cf42d 100644
>>> --- a/gdb/testsuite/lib/gdb.exp
>>> +++ b/gdb/testsuite/lib/gdb.exp
>>> @@ -10034,6 +10034,9 @@ proc gdb_get_worker_threads { {testname ""} } {
>>>    	-wrap -re "^The number of worker threads GDB can use is unlimited \\(currently ($::decimal)\\)\\." {
>>>    	    set worker_threads $expect_out(1,string)
>>>    	}
>>> +	-wrap -re "^The number of worker threads GDB can use is the default \\(currently ($::decimal)\\)\\." {
>>> +	    set worker_threads $expect_out(1,string)
>>> +	}
>>>    	-wrap -re "^The number of worker threads GDB can use is ($::decimal)\\." {
>>>    	    set worker_threads $expect_out(1,string)
>>>    	}
>>
>> This is new:
>>
>> 33ae45434d0ab1f7de365b9140ad4e4ffc34b8a2
>> Date:   Mon Dec 4 14:23:17 2023 +0000
>>
>>       gdb: Enable early init of thread pool size
>>
>> That commit changes the "is unlimited" text from
>> maintenance_show_worker_threads to "is the default":
>>
>>          gdb_printf (file, _("The number of worker threads GDB "
>> -                         "can use is unlimited (currently %zu).\n"),
>> +                         "can use is the default (currently %zu).\n"),
>>                     gdb::thread_pool::g_thread_pool->thread_count ());
>>
>> So this patch can be further simplified. Otherwise LGTM.
> 
> Indeed.  This was my mistake for not retesting after the final rebase.
> As Keith said s/unlimited/the default/ instead of adding a whole new
> regexp, and this is good to go.
> 
> Approved-By: Andrew Burgess <aburgess@redhat.com>

FTR, AFAICT this already has been fixed by commit 66e00622a89 
("gdb/testsuite: Update worker thread show assertion").

Thanks,
- Tom