From: Bruno Larsen <blarsen@redhat.com>
To: Stephan Rohr <stephan.rohr@intel.com>, gdb-patches@sourceware.org
Cc: tom@tromey.com
Subject: Re: [PATCH 1/1] gdb/dwarf2: Fix 'rw_pieced_value' for values casted to different type.
Date: Mon, 6 Jun 2022 13:51:32 -0300 [thread overview]
Message-ID: <05ef77d7-d6c0-bdcc-8839-4dfa29248b6c@redhat.com> (raw)
In-Reply-To: <20220422144420.3545190-2-stephan.rohr@intel.com>
Hello Stephan
Your patch does not seem to introduce any regression and fixes the test, so I'd say it looks alright. Unfortunately, I can't approve patches, so let's hope a global maintainer looks at it.
Cheers!
Bruno Larsen
On 4/22/22 11:44, Stephan Rohr via Gdb-patches wrote:
next prev parent reply other threads:[~2022-06-06 16:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 14:44 [PATCH 0/1] " Stephan Rohr
2022-04-22 14:44 ` [PATCH 1/1] gdb/dwarf2: " Stephan Rohr
2022-06-06 16:51 ` Bruno Larsen [this message]
2022-07-14 7:50 ` Rohr, Stephan
2022-07-21 12:21 ` Rohr, Stephan
2022-08-02 6:30 ` Rohr, Stephan
2022-08-11 7:09 ` Rohr, Stephan
2022-08-19 7:41 ` Rohr, Stephan
2022-08-19 16:39 ` Simon Marchi
2022-10-11 8:03 ` Rohr, Stephan
2022-10-21 17:06 ` Tom Tromey
2022-10-14 18:28 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05ef77d7-d6c0-bdcc-8839-4dfa29248b6c@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=stephan.rohr@intel.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).