From: Simon Marchi <simon.marchi@polymtl.ca>
To: Lancelot SIX <lsix@lancelotsix.com>,
Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [pushed] gdb: make frame_register static
Date: Tue, 6 Dec 2022 10:43:13 -0500 [thread overview]
Message-ID: <0880f1d0-7983-e6f7-b66e-f08bb31bf975@polymtl.ca> (raw)
In-Reply-To: <20221206145202.lah7uwybcvv4akqi@octopus>
On 12/6/22 09:52, Lancelot SIX wrote:
> Hi Simon,
>
> The function frame_register is used outside of frame.c in the rocgdb
> downstream port. Do you think we could revert this patch here?
> Otherwise, this can be a change we keep downstream.
I think it would make sense to make the function non-static in the
downstream port, and then provide a patch that makes it non-static
upstream when submitting the code that needs it outside of frame.c.
Here, I happen to be involved in this port, but that is what I would
answer to anybody else in the same situation.
Simon
prev parent reply other threads:[~2022-12-06 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 18:32 Simon Marchi
2022-12-06 14:52 ` Lancelot SIX
2022-12-06 15:43 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0880f1d0-7983-e6f7-b66e-f08bb31bf975@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).