From: John Baldwin <jhb@FreeBSD.org>
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/5] Various inferior / arch cleanups
Date: Fri, 6 Oct 2023 15:05:41 -0700 [thread overview]
Message-ID: <0b4cad10-dc87-6645-e397-18f26c9f04dc@FreeBSD.org> (raw)
In-Reply-To: <20230929182541.138320-1-simon.marchi@efficios.com>
On 9/29/23 2:24 PM, Simon Marchi via Gdb-patches wrote:
> I'm in the middle of a bigger change, moving things around, and
> extracted these patches which make sense on their own, I think. No
> changes in behavior expected.
>
> Simon Marchi (5):
> gdb: add inferior::{arch, set_arch}
> gdb: add inferior parameter to architecture_changed observable
> gdb: move set_target_gdbarch to inferior::set_arch
> gdb: remove target_gdbarch
> gdb: scope down registers_changed call in inferior::set_arch
>
> gdb/aarch64-linux-nat.c | 14 ++--
> gdb/ada-lang.c | 7 +-
> gdb/ada-tasks.c | 9 +--
> gdb/aix-thread.c | 5 +-
> gdb/amd-dbgapi-target.c | 4 +-
> gdb/amd64-linux-nat.c | 2 +-
> gdb/arc-tdep.c | 5 +-
> gdb/arch-utils.c | 31 +++------
> gdb/arm-fbsd-tdep.c | 2 +-
> gdb/arm-tdep.c | 15 ++--
> gdb/auxv.c | 21 +++---
> gdb/break-catch-syscall.c | 2 +-
> gdb/breakpoint.c | 16 ++---
> gdb/bsd-uthread.c | 15 ++--
> gdb/btrace.c | 3 +-
> gdb/cli/cli-dump.c | 5 +-
> gdb/compile/compile-c-symbols.c | 12 ++--
> gdb/compile/compile-cplus-symbols.c | 12 ++--
> gdb/compile/compile-object-load.c | 52 +++++++-------
> gdb/corefile.c | 3 +-
> gdb/corelow.c | 2 +-
> gdb/cp-namespace.c | 3 +-
> gdb/cp-support.c | 3 +-
> gdb/d-namespace.c | 3 +-
> gdb/darwin-nat-info.c | 12 ++--
> gdb/dcache.c | 6 +-
> gdb/disasm.c | 11 +--
> gdb/elfread.c | 4 +-
> gdb/fbsd-nat.c | 2 +-
> gdb/filesystem.c | 3 +-
> gdb/frame-unwind.c | 3 +-
> gdb/gcore-elf.c | 2 +-
> gdb/gcore.c | 49 ++++++-------
> gdb/gdbarch.h | 24 +------
> gdb/gnu-nat.c | 6 +-
> gdb/i386-darwin-nat.c | 8 +--
> gdb/i386-tdep.c | 6 +-
> gdb/ia64-vms-tdep.c | 2 +-
> gdb/infcmd.c | 8 +--
> gdb/inferior.c | 19 ++++-
> gdb/inferior.h | 33 +++++----
> gdb/infrun.c | 19 ++---
> gdb/jit.c | 5 +-
> gdb/linux-nat.c | 10 +--
> gdb/linux-tdep.c | 6 +-
> gdb/memattr.c | 9 +--
> gdb/mep-tdep.c | 4 +-
> gdb/mi/mi-interp.c | 8 +--
> gdb/mi/mi-main.c | 2 +-
> gdb/microblaze-tdep.c | 2 +-
> gdb/mips-linux-nat.c | 6 +-
> gdb/mips-linux-tdep.c | 5 +-
> gdb/mips-tdep.c | 15 ++--
> gdb/moxie-tdep.c | 4 +-
> gdb/msp430-tdep.c | 3 +-
> gdb/netbsd-nat.c | 2 +-
> gdb/nto-procfs.c | 5 +-
> gdb/nto-tdep.c | 29 ++++----
> gdb/observable.h | 5 +-
> gdb/ppc-linux-nat.c | 2 +-
> gdb/ppc-linux-tdep.c | 2 +-
> gdb/printcmd.c | 66 +++++++++---------
> gdb/proc-service.c | 2 +-
> gdb/process-stratum-target.c | 2 +-
> gdb/process-stratum-target.h | 3 +-
> gdb/procfs.c | 24 ++++---
> gdb/progspace.c | 10 +--
> gdb/python/py-finishbreakpoint.c | 2 +-
> gdb/python/py-inferior.c | 16 ++---
> gdb/python/py-objfile.c | 5 +-
> gdb/python/py-progspace.c | 5 +-
> gdb/python/py-record-btrace.c | 2 +-
> gdb/python/py-unwind.c | 2 +-
> gdb/python/python.c | 4 +-
> gdb/ravenscar-thread.c | 7 +-
> gdb/record-btrace.c | 2 +-
> gdb/record-full.c | 19 +++--
> gdb/regcache-dump.c | 6 +-
> gdb/regcache.c | 8 +--
> gdb/remote-sim.c | 2 +-
> gdb/remote.c | 73 +++++++++++---------
> gdb/rl78-tdep.c | 6 +-
> gdb/rs6000-aix-nat.c | 5 +-
> gdb/rs6000-tdep.c | 2 +-
> gdb/rust-parse.c | 5 +-
> gdb/rx-tdep.c | 5 +-
> gdb/s390-linux-nat.c | 2 +-
> gdb/scoped-mock-context.h | 2 +-
> gdb/sol-thread.c | 13 ++--
> gdb/solib-darwin.c | 30 ++++----
> gdb/solib-dsbt.c | 26 +++----
> gdb/solib-frv.c | 19 ++---
> gdb/solib-rocm.c | 2 +-
> gdb/solib-svr4.c | 88 ++++++++++++++----------
> gdb/solib.c | 37 +++++-----
> gdb/sparc64-tdep.c | 14 ++--
> gdb/symfile-mem.c | 4 +-
> gdb/symfile.c | 11 +--
> gdb/symtab.c | 6 +-
> gdb/target-descriptions.c | 4 +-
> gdb/target.c | 33 +++++----
> gdb/target.h | 2 +-
> gdb/tracefile-tfile.c | 25 ++++---
> gdb/tracefile.c | 3 +-
> gdb/tracepoint.c | 31 ++++-----
> gdb/tui/tui-disasm.c | 2 +-
> gdb/unittests/frame_info_ptr-selftests.c | 2 +-
> gdb/value.c | 4 +-
> gdb/windows-nat.c | 2 +-
> gdb/windows-tdep.c | 10 +--
> gdb/z80-tdep.c | 2 +-
> 111 files changed, 667 insertions(+), 577 deletions(-)
>
>
> base-commit: 4ebfd53de03599b73838ee339e47652ac26c37c0
I only skimmed these, but these seem ok to me in principle.
--
John Baldwin
next prev parent reply other threads:[~2023-10-06 22:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 18:24 Simon Marchi
2023-09-29 18:24 ` [PATCH 1/5] gdb: add inferior::{arch, set_arch} Simon Marchi
2023-09-29 18:24 ` [PATCH 2/5] gdb: add inferior parameter to architecture_changed observable Simon Marchi
2023-09-29 18:24 ` [PATCH 3/5] gdb: move set_target_gdbarch to inferior::set_arch Simon Marchi
2023-09-29 18:24 ` [PATCH 4/5] gdb: remove target_gdbarch Simon Marchi
2023-09-29 18:24 ` [PATCH 5/5] gdb: scope down registers_changed call in inferior::set_arch Simon Marchi
2023-10-06 22:05 ` John Baldwin [this message]
2023-10-10 14:43 ` [PATCH 0/5] Various inferior / arch cleanups Simon Marchi
2023-10-10 14:55 ` Guinevere Larsen
2023-10-10 15:05 ` Simon Marchi
2023-10-09 9:42 ` Andrew Burgess
2023-10-10 14:48 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b4cad10-dc87-6645-e397-18f26c9f04dc@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).