From: Andrei Pikas <gdb@mail.api.win>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v6] Add an option with a color type.
Date: Fri, 19 Apr 2024 22:52:39 +0300 [thread overview]
Message-ID: <0c39e31d-bcfe-4c07-887b-19262c3f6afb@mail.api.win> (raw)
In-Reply-To: <877cgtup03.fsf@tromey.com>
Hi. In PATCH v6 I have fixed all problems mentioned in all previous
versions. But after that it became stale and no one reviewed it. What is
a copyright assignment and how can I give it to you? I allow anyone to
use my code from this patch without any restrictions and I will be glad
if it gets be merged.
On 19/04/2024 22:33, Tom Tromey wrote:
>>>>>> "Andrei" == Andrei Pikas <gdb@mail.api.win> writes:
> Hi.
>
> Andrei> Colors can be specified as "none" for terminal's default color, as a name of
> Andrei> one of the eight standard colors of ISO/IEC 6429 "black", "red", "green", etc.,
> Andrei> as an RGB hexadecimal tripplet #RRGGBB for 24-bit TrueColor, or as an
> Andrei> integer from 0 to 255. Integers 0 to 7 are the synonyms for the standard
> Andrei> colors. Integers 8-15 are used for the so-called bright colors from the
> Andrei> aixterm extended 16-color palette. Integers 16-255 are the indexes into xterm
> Andrei> extended 256-color palette (usually 6x6x6 cube plus gray ramp). In
> Andrei> general, 256-color palette is terminal dependent and sometimes can be
> Andrei> changed with OSC 4 sequences, e.g. "\033]4;1;rgb:00/FF/00\033\\".
>
> Andrei> It is the responsibility of the user to verify that the terminal supports
> Andrei> the specified colors.
>
> Whatever happened with this patch?
>
> IIRC I didn't review it, since I thought someone else was handling it,
> and then it never went in... anyway I was recently thinking about RGB
> support for styles, and I remembered it.
>
> Do you have a copyright assignment?
> If so I can review it and we can try again to get it in.
>
> thanks,
> Tom
next prev parent reply other threads:[~2024-04-19 19:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 11:40 [PATCH v4] " Andrei Pikas
2022-10-16 13:45 ` Eli Zaretskii
2022-10-16 16:03 ` [PATCH v5] " Andrei Pikas
2022-10-16 16:22 ` Eli Zaretskii
2022-10-16 16:28 ` [PATCH v6] " Andrei Pikas
2022-10-16 16:45 ` Eli Zaretskii
2024-04-19 19:33 ` Tom Tromey
2024-04-19 19:52 ` Andrei Pikas [this message]
2024-04-19 20:19 ` Tom Tromey
2024-04-20 18:24 ` Tom Tromey
2024-04-20 18:32 ` Andrei Pikas
2024-05-11 15:17 ` Andrei Pikas
2024-05-13 19:02 ` Tom Tromey
2024-05-21 9:00 ` Andrei Pikas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c39e31d-bcfe-4c07-887b-19262c3f6afb@mail.api.win \
--to=gdb@mail.api.win \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).