From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] [gdb/cli] Fix wrapping for TERM=ansi
Date: Tue, 2 May 2023 15:40:21 +0200 [thread overview]
Message-ID: <0d477c40-c6c2-5f7e-9a8a-9136d339e086@suse.de> (raw)
In-Reply-To: <f17d45f4-ef4d-b7b6-e871-3287c8fbc951@suse.de>
On 4/15/23 10:10, Tom de Vries via Gdb-patches wrote:
> On 4/15/23 08:09, Tom de Vries via Gdb-patches wrote:
>> [ This patch requires readline_hidden_col, introduced by this patch (
>> https://sourceware.org/pipermail/gdb-patches/2023-April/198877.html ). ]
>
> Hi,
>
> I see I accidentally formatted this as a 2/2 patch. The 1/2 is
> obviously the readline_hidden_cols part of the patch mentioned above.
>
> I can submit that part separately, if anybody thinks that's a good idea,
> but for now I'm hoping aforementioned patch will get accepted, and
> there'll be no need.
>
I've submitted a v2 here (
https://sourceware.org/pipermail/gdb-patches/2023-May/199260.html ).
Changes v2 vs v1:
- no longer fixing this in set_screen_size, but instead in
init_page_info.
- more extensive analysis in commit log, also covers PR cli/30411
which is caused by the same root cause.
- came to the conclusion that "set width" is only supposed to be
used to set the screen width, updated help text and doc to
make that more clear.
Thanks,
- Tom
prev parent reply other threads:[~2023-05-02 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-15 6:09 Tom de Vries
2023-04-15 8:10 ` Tom de Vries
2023-05-02 13:40 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d477c40-c6c2-5f7e-9a8a-9136d339e086@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).