From: Pedro Alves <pedro@palves.net>
To: Andrew Burgess <aburgess@redhat.com>, Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.arch/i386-avx.exp with clang
Date: Fri, 5 Nov 2021 12:24:53 +0000 [thread overview]
Message-ID: <0d650a1b-5202-d0dd-d346-f73704b5f594@palves.net> (raw)
In-Reply-To: <20211105115404.GA1816063@redhat.com>
On 2021-11-05 11:54, Andrew Burgess via Gdb-patches wrote:
> * Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> [2021-11-05 10:43:38 +0100]:
>>> I see the same problem. Did you consider using:
>>>
>>> /* Some useful comment .... */
>>> v8sf_t data[] __attribute__ ((aligned(32))) = ....
>>>
>>> this seems to fix the problem on clang for me, and still works fine
>>> with gcc.
>>
>> I did consider this, and decided against it because it's not
>> portable.
>>
>> Note btw that there is no other usage of this:
>> ...
>> $ find gdb/testsuite/ -type f | xargs grep attribute.*align
>> $
>
> No, but in gdb/testsuite/lib/attribute.h we do setup a compatibility
> macro for 'noclone', so there's definitely precedent for using
> attributes that might not be supported everywhere.
>
> I'd hope most production level compilers would, if they don't support
> 'aligned' have something similar/equivalent.
>
> Personally, I'd go with a compatibility macro, and let folk who care
> about other compilers figure out what they need when they hit the
> problem.
I agree, and I'm not aware of any serious production compiler that doesn't
support some way of forcing alignment.
Pedro Alves
> But I'm not blocking your proposed solution if you feel
> strongly about it.
prev parent reply other threads:[~2021-11-05 12:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 13:55 Tom de Vries
2021-11-05 9:33 ` Andrew Burgess
2021-11-05 9:43 ` Tom de Vries
2021-11-05 11:54 ` Andrew Burgess
2021-11-05 12:23 ` Tom de Vries
2021-11-05 12:55 ` Pedro Alves
2021-11-05 13:15 ` Tom de Vries
2021-11-05 13:20 ` Pedro Alves
2021-11-05 13:35 ` Tom de Vries
2021-11-05 13:52 ` Andrew Burgess
2021-12-06 15:27 ` Tom de Vries
2021-11-05 13:54 ` Pedro Alves
2021-12-06 15:25 ` Tom de Vries
2021-11-05 12:24 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d650a1b-5202-d0dd-d346-f73704b5f594@palves.net \
--to=pedro@palves.net \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).