From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>,
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [gdb/cli] Make quit really quit after remote connection closed
Date: Tue, 8 Nov 2022 18:52:16 +0100 [thread overview]
Message-ID: <0e9b1bd1-c99e-953a-48f7-4be9c94f15f0@suse.de> (raw)
In-Reply-To: <871qqd5pam.fsf@tromey.com>
On 11/8/22 18:28, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Tom> But when doing monitor exit followed by quit with confirmation, we get the gdb
> Tom> prompt back, requiring us to do quit once more:
>
> Thanks for doing this.
>
> Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=15746
>
> I think mentioning "PR server/15746" in the commit message would cause
> this to show up in bugzilla.
>
I've tried that, but that didn't seem to work. Maybe I need to wait
longer, I'm not sure.
> Other than that, this looks good to me.
thanks for the review, committed.
- Tom
next prev parent reply other threads:[~2022-11-08 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 17:50 Tom de Vries
2022-11-08 17:28 ` Tom Tromey
2022-11-08 17:52 ` Tom de Vries [this message]
2022-11-08 19:40 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e9b1bd1-c99e-953a-48f7-4be9c94f15f0@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).