Re: [PATCH] gdb: Workaround stringop-overread warning in debuginfod-support.c on powerpc64

[Mark Wielaard <mark@klomp.org>]

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

Hi Simon,

On Wed, 2022-05-11 at 20:49 -0400, Simon Marchi wrote:
> On 2022-05-11 18:52, Mark Wielaard wrote:
> > Alternatively we could just suppress this warning for any
> > architecture.
> 
> Let's make a deal, if you find a 3rd architecture where this is the
> case we do that, alright? ;)

Got another on hppa:
https://sourceware.org/bugzilla/show_bug.cgi?id=29198

So, ok to push the attached?

Thanks,

Mark

[-- Attachment #2: 0001-gdb-Always-suppress-stringop-overread-warning-in-deb.patch --]
[-- Type: text/x-patch, Size: 1767 bytes --]

From 0a1bd604d3037272d89c7c3e9ddc02e513e1027a Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Tue, 31 May 2022 11:00:06 +0200
Subject: [PATCH] gdb: Always suppress stringop-overread warning in
 debuginfod-support.c

Just like on s390x with g++ 11.2.1 and ppc64le with g++ 11.3.1 g++ 11
on hppa produces a spurious warning for stringop-overread in
debuginfod_is_enabled for url_view. Just always suppress it on all
arches.

https://sourceware.org/bugzilla/show_bug.cgi?id=29198

gdb/ChangeLog:

	* debuginfod-support.c (debuginfod_is_enabled): Always use
	DIAGNOSTIC_IGNORE_STRINGOP_OVERREAD.
---
 gdb/debuginfod-support.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c
index 6dc08fc29b6..bd355b67352 100644
--- a/gdb/debuginfod-support.c
+++ b/gdb/debuginfod-support.c
@@ -193,17 +193,14 @@ debuginfod_is_enabled ()
 	  if (off == gdb::string_view::npos)
 	    break;
 	  url_view = url_view.substr (off);
-#if defined (__s390x__) || defined (__powerpc64__)
-	  /* g++ 11.2.1 on s390x and g++ 11.3.1 on ppc64le seem convinced
-	     url_view might be of SIZE_MAX length.  And so complains
-	     because the length of an array can only be PTRDIFF_MAX.  */
+	  /* g++ 11.2.1 on s390x, g++q 11.3.1 on ppc64le and g++ 11 on
+	     hppa seem convinced url_view might be of SIZE_MAX length.
+	     And so complains because the length of an array can only
+	     be PTRDIFF_MAX.  */
 	  DIAGNOSTIC_PUSH
 	  DIAGNOSTIC_IGNORE_STRINGOP_OVERREAD
-#endif
 	  off = url_view.find_first_of (' ');
-#if defined (__s390x__) || defined (__powerpc64__)
 	  DIAGNOSTIC_POP
-#endif
 	  gdb_printf
 	    (_("  <%ps>\n"),
 	     styled_string (file_name_style.style (),
-- 
2.18.4