From: Pedro Alves <pedro@palves.net>
To: Mark Wielaard <mark@klomp.org>, Simon Marchi <simark@simark.ca>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Workaround stringop-overread warning in debuginfod-support.c on powerpc64
Date: Tue, 31 May 2022 10:46:38 +0100 [thread overview]
Message-ID: <99342989-cf95-0194-bd61-1f41292e8c72@palves.net> (raw)
In-Reply-To: <0f5c5a76969801002e5b2f9b224e6bdc58b41c1d.camel@klomp.org>
On 2022-05-31 10:05, Mark Wielaard wrote:
> + /* g++ 11.2.1 on s390x, g++q 11.3.1 on ppc64le and g++ 11 on
> + hppa seem convinced url_view might be of SIZE_MAX length.
> + And so complains because the length of an array can only
> + be PTRDIFF_MAX. */
I wonder whether sticking in an assert so that the compiler knows the
size of array, would make the warning go away:
diff --git c/gdb/debuginfod-support.c w/gdb/debuginfod-support.c
index 6dc08fc29b6..d6fab39eac8 100644
--- c/gdb/debuginfod-support.c
+++ w/gdb/debuginfod-support.c
@@ -187,6 +187,8 @@ debuginfod_is_enabled ()
"from the following URLs:\n"));
gdb::string_view url_view (urls);
+ gdb_assert (url_view.size () < PTRDIFF_MAX);
+
while (true)
{
size_t off = url_view.find_first_not_of (' ');
next prev parent reply other threads:[~2022-05-31 9:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 22:52 Mark Wielaard
2022-05-12 0:49 ` Simon Marchi
2022-05-31 9:05 ` Mark Wielaard
2022-05-31 9:46 ` Pedro Alves [this message]
2022-05-31 10:51 ` Mark Wielaard
2022-06-06 11:27 ` Mark Wielaard
2022-06-06 16:42 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99342989-cf95-0194-bd61-1f41292e8c72@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=mark@klomp.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).