Re: [PATCH] Remove reset_ecs

[Simon Marchi <simark@simark.ca>]

On 11/21/22 12:58, Tom Tromey wrote:
> I noticed that execution_control_state has a 'reset' method, and
> there's also a 'reset_ecs' function that calls it.  This patch cleans
> this area up a little by adding a parameter to the constructor and the
> reset method.  Some extraneous variables are also removed, like here:
> 
> -      struct execution_control_state ecss;
> -      struct execution_control_state *ecs = &ecss;
> 
> Here 'ecs' is never changed, so this patch removes it entirely in
> favor of just using the object everywhere.

I think we could get rid of the reset method as well, it's not used
outside of the constructor.  Like this:

    struct execution_control_state
    {
      explicit execution_control_state (thread_info *thr = nullptr)
        : ptid (thr != nullptr ? thr->ptid : null_ptid), event_thread (thr)
      {}

      process_stratum_target *target = nullptr;
      ptid_t ptid;
      /* The thread that got the event, if this was a thread event; NULL
         otherwise.  */
      struct thread_info *event_thread;

      target_waitstatus ws;
      int stop_func_filled_in = 0;
      CORE_ADDR stop_func_start = 0;
      CORE_ADDR stop_func_end = 0;
      const char *stop_func_name = nullptr;
      int wait_some_more = 0;

      /* True if the event thread hit the single-step breakpoint of
         another thread.  Thus the event doesn't cause a stop, the thread
         needs to be single-stepped past the single-step breakpoint before
         we can switch back to the original stepping thread.  */
      int hit_singlestep_breakpoint = 0;
    };

Simon