From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove reset_ecs
Date: Sat, 26 Nov 2022 15:32:40 -0500 [thread overview]
Message-ID: <1ff352e2-7e07-a818-01ff-3004142a1eef@simark.ca> (raw)
In-Reply-To: <87edtqbhx7.fsf@tromey.com>
> diff --git a/gdb/infrun.c b/gdb/infrun.c
> index 96346e1f25b..248b71a053b 100644
> --- a/gdb/infrun.c
> +++ b/gdb/infrun.c
> @@ -1854,55 +1854,33 @@ displaced_step_finish (thread_info *event_thread, enum gdb_signal signal)
> discarded between events. */
> struct execution_control_state
> {
> - execution_control_state ()
> + explicit execution_control_state (thread_info *thr = nullptr)
> + : ptid (thr == nullptr ? null_ptid : thr->ptid),
> + event_thread (thr),
> + ws (target_waitstatus ())
Not sure, but I feel like setting ws like this is unnecessary. It will
be default-constructed the same way if we specify nothing, I believe.
In any case:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2022-11-26 20:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 17:58 Tom Tromey
2022-11-21 18:14 ` Simon Marchi
2022-11-26 1:53 ` Tom Tromey
2022-11-26 20:32 ` Simon Marchi [this message]
2022-11-28 19:19 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ff352e2-7e07-a818-01ff-3004142a1eef@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).