Re: [PATCH] gdb: add .pre-commit-config.yaml

[Guinevere Larsen <blarsen@redhat.com>]

I have no real opinion on pre-commit, one way or another, but I like the 
idea of automating easily-forgotten things. could even be upgraded to 
rerunning gdbarch.py at some point!

On 11/03/2024 16:09, Simon Marchi wrote:
> I will add these instructions to the wiki if this patch gets merged, so
> they are easy to find.  We could perhaps think of having a
> gdb/CONTRIBUTING document of some sort checked in the repo with that
> kind of information.

I have positive opinions on this, however! I don't find the contribution 
checklist on the wiki to be a good description of the contribution 
process of GDB. I'm not sure what I know from there and what is 
essential tribal knowledge that I got from internal talks and incorrect 
submissions that were corrected. The maintainers file is the closest we 
have to describing the process, and someone who doesn't know the project 
would not think of looking there, I don't think (I know I didn't).

So I would be very happy to see a contributing file, where the process 
as a whole is described in order, before going down to the minutiae of 
how to make a good contribution. One and done things like pre-commit, 
choosing a way to send email, copyright attribution, can be easily 
viewed by prospecting contributors, and previous contributors can 
refresh their minds or quickly check some recent process change.

-- 
Cheers,
Guinevere Larsen
She/Her/Hers