From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH] gdb: add .pre-commit-config.yaml
Date: Mon, 11 Mar 2024 14:26:03 -0600 [thread overview]
Message-ID: <87r0ggo6qs.fsf@tromey.com> (raw)
In-Reply-To: <20240311150947.71762-1-simon.marchi@efficios.com> (Simon Marchi's message of "Mon, 11 Mar 2024 11:09:43 -0400")
>>>>> Simon Marchi <simon.marchi@efficios.com> writes:
> Using pre-commit to run hooks is opt-in, as in it's not mandatory at all
> for development
Important point for binutils.
> I have not used pre-commit in a real project before, but have heard good
> things from it.
We use it internally at AdaCore. It seems totally fine, I've rarely had
any issue with it, and it's pretty easy to bypass should the need arise.
So, +1 from me.
thanks,
Tom
next prev parent reply other threads:[~2024-03-11 20:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 15:09 Simon Marchi
2024-03-11 20:26 ` Tom Tromey [this message]
2024-03-12 10:50 ` Guinevere Larsen
2024-03-20 13:44 ` Andrew Burgess
2024-03-20 15:56 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0ggo6qs.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).