From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>,
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3 0/2] Write DWARF index cache files in background
Date: Fri, 24 Feb 2023 16:44:34 -0500 [thread overview]
Message-ID: <1154aa3c-4ef9-80ef-c551-35a9ce8bf294@simark.ca> (raw)
In-Reply-To: <87k006j3zz.fsf@tromey.com>
On 2/24/23 13:46, Tom Tromey via Gdb-patches wrote:
>>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Tom> Here's v3 of the patches to write the DWARF index in the background.
> Tom> v2 was here:
>
> Tom> https://sourceware.org/pipermail/gdb-patches/2022-June/189889.html
>
> Tom> This hides a user-noticeable pause when the feature is enabled. (Note
> Tom> that, when the feature is used in batch mode, the pause is still
> Tom> seen.)
>
> Tom> This version of the series fixes a possible race that I found in v2.
> Tom> Essentially, the index-writing background job must be started after
> Tom> all the finalization tasks have started. There's a comment in the
> Tom> code explaining this.
>
> I'm checking this in now.
>
> Tom
I started seeing this, I guess it's related:
FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: at least one file was created
FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: expected file is there
Simon
next prev parent reply other threads:[~2023-02-24 21:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 16:45 Tom Tromey
2022-12-19 16:45 ` [PATCH v3 1/2] Only use the per-BFD object to write a DWARF index Tom Tromey
2022-12-19 16:45 ` [PATCH v3 2/2] Write the DWARF index in the background Tom Tromey
2023-02-24 18:46 ` [PATCH v3 0/2] Write DWARF index cache files in background Tom Tromey
2023-02-24 21:44 ` Simon Marchi [this message]
2023-03-02 15:51 ` Tom Tromey
2023-03-03 16:41 ` Tom Tromey
2023-03-03 17:22 ` Simon Marchi
2023-03-03 17:29 ` Tom Tromey
2023-03-03 17:52 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1154aa3c-4ef9-80ef-c551-35a9ce8bf294@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).