New ARI warning Sat Jan 10 01:54:00 UTC 2015

New ARI warning Sat Jan 10 01:54:00 UTC 2015

[GDB Administrator]

315a316
> gdb/linux-nat.c:1184: gettext: trailing new line: A message should not have a trailing new line
gdb/linux-nat.c:1184:	      warning (_("Cannot attach to lwp %d: %s\n"),
420a422,424
> gdb/nat/linux-procfs.c:215: gettext: trailing new line: A message should not have a trailing new line
gdb/nat/linux-procfs.c:215:      warning (_("Could not open /proc/%ld/task.\n"), (long) pid);
> gdb/nat/linux-ptrace.c:76: regression: strerror: Do not use strerror(), instead use safe_strerror()
gdb/nat/linux-ptrace.c:76:				strerror (err), err, warnings);
> gdb/nat/linux-ptrace.c:79: regression: strerror: Do not use strerror(), instead use safe_strerror()
gdb/nat/linux-ptrace.c:79:				strerror (err), err);
714d717
< gdb/tui/tui-hooks.c:266: deprecated: deprecated query_hook: Do not use deprecated query_hook, see declaration for details
gdb/tui/tui-hooks.c:266:  deprecated_query_hook = tui_query_hook;
759d761
< gdb/utils.c:1552: code: OP eol: Do not use &&, or || at the end of a line
gdb/utils.c:1552:      (c >= 0x7F && c < 0xA0) ||	 

[PATCH 2/2] [ARI] Remove trailing new-line in argument of call to warning.

[Joel Brobecker]

gdb/ChangeLog:

        * nat/linux-procfs.c (linux_proc_attach_tgid_threads):
        Remove trailing new-line in argument of call to warning.
---
 gdb/ChangeLog          | 5 +++++
 gdb/nat/linux-procfs.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7ee17d7..bb66830 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2015-01-13  Joel Brobecker  <brobecker@adacore.com>
 
+	* nat/linux-procfs.c (linux_proc_attach_tgid_threads):
+	Remove trailing new-line in argument of call to warning.
+
+2015-01-13  Joel Brobecker  <brobecker@adacore.com>
+
 	* linux-nat.c (attach_proc_task_lwp_callback): Remove trailing
 	new-line in argument of call to "warning".
 
diff --git a/gdb/nat/linux-procfs.c b/gdb/nat/linux-procfs.c
index 00b6a70..5dd2b92 100644
--- a/gdb/nat/linux-procfs.c
+++ b/gdb/nat/linux-procfs.c
@@ -212,7 +212,7 @@ linux_proc_attach_tgid_threads (pid_t pid,
   dir = opendir (pathname);
   if (dir == NULL)
     {
-      warning (_("Could not open /proc/%ld/task.\n"), (long) pid);
+      warning (_("Could not open /proc/%ld/task."), (long) pid);
       return;
     }
 
-- 
1.9.1

[PATCH 1/2] [ARI] Remove trailing new-line in argument of call to warning.

[Joel Brobecker]

gdb/ChangeLog:

	* linux-nat.c (attach_proc_task_lwp_callback): Remove trailing
	new-line in argument of call to "warning".
---
 gdb/ChangeLog   | 5 +++++
 gdb/linux-nat.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6610b77..7ee17d7 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2015-01-13  Joel Brobecker  <brobecker@adacore.com>
 
+	* linux-nat.c (attach_proc_task_lwp_callback): Remove trailing
+	new-line in argument of call to "warning".
+
+2015-01-13  Joel Brobecker  <brobecker@adacore.com>
+
 	* ada-lang.c (ada_lookup_symbol_nonlocal): If name not found
 	in static block, then try searching for primitive types.
 
diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index 5f2c176b..a8a63cf 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -1181,7 +1181,7 @@ attach_proc_task_lwp_callback (ptid_t ptid)
 	    }
 	  else
 	    {
-	      warning (_("Cannot attach to lwp %d: %s\n"),
+	      warning (_("Cannot attach to lwp %d: %s"),
 		       lwpid,
 		       linux_ptrace_attach_fail_reason_string (ptid,
 							       err));
-- 
1.9.1

Re: New ARI warning Sat Jan 10 01:54:00 UTC 2015

[Joel Brobecker]

This set of patches fixes 2 of the new ARI violations reported by
last Saturday's report. The other 2 should also be fixed, IMO
(use safe_strerror instead of strerror, because strerror may return
NULL for unknown errno), but is requires us to move safe_strerror
to the common area, knowning that there is one POSIX implementation
and a Windows one. So a little bit more work, left for another day.

The two patches were tested on x86_64-linux, and then pushed.

[PATCH 1/2] [ARI] Remove trailing new-line in argument of call to
[PATCH 2/2] [ARI] Remove trailing new-line in argument of call to

Thank you,
-- 
Joel