Re: [PATCH 4/5] gdb/testsuite: change newline patterns used in gdb_test

[Tom de Vries <tdevries@suse.de>]

On 5/1/23 16:33, Andrew Burgess wrote:
> Tom de Vries <tdevries@suse.de> writes:
> 
>> On 3/31/23 22:20, Andrew Burgess via Gdb-patches wrote:
>>> This commit makes two changes to how we match newline characters in
>>> the gdb_test proc.
>>
>> Hi,
>>
>> the -wrap used in gdb_test_multiple is defined in terms of gdb_test
>> semantics, but it doesn't seem to have been updated to match the new
>> behaviour in gdb_test.
>>
>> I've filed a PR about this regression (
>> https://sourceware.org/bugzilla/show_bug.cgi?id=30403 ).
> 
> Sorry for any problems caused.  I'm not working today, but if this has
> not been addressed, I'll look at this on Tuesday.

AFAIU it's a silent regression, so there are no problems in term of 
FAILs, it's just that more work is required.

FWIW, I think the root cause for introducing this regression silently is 
that we try to implement the same thing in two different locations, and 
it's just easy for things to get out of sync.  I recently fixed 
something similar in commit 4fa173cfd79 ("[gdb/testsuite] Fix -wrap in 
presence of -prompt in gdb_test_multiple"), that's why I noticed it.

Thanks,
- Tom