[PATCH] Sync readline/ to version 7.0 alpha

[PATCH] Sync readline/ to version 7.0 alpha

[Patrick Palka]

This patch syncs our upstream copy of readline from version 6.2 to the
latest version, 7.0 alpha (released July 10 2015).

I essentially copied what was done the last time readline was synced,
when Jan updated to readline 6.2 in 2011:
http://sourceware.org/ml/gdb-patches/2011-05/msg00003.html

Procedure:

1. I extracted the readline-7.0-alpha tarball on top of readline/.
2. I deleted all the new files under doc/ that were deliberately omitted
   before.
3. I regenerated readline/configure and readline/examples/rlfe/configure
   using autoconf 2.64.  No other configure files need regenerating.
4. I updated the function gdb_printable_part in completer.c with a
   trivial change made to the readline function it is based off of,
   printable_part in readline/complete.c.  There is more work to be done in
   completer.c to sync it with readline/complete.c, but it is non-trivial
   and should probably be done separately anyway.

Local patches that had to be reapplied:

    None.  readline 7.0 alpha contains all of our local readline
    patches.  [This is especially convenient because it allows us forego
    a consensus on how to manage local patches across readline syncs :)]

New files in readline/:

    colors.{c,h}
    examples/{hist_erasedups,hist_purgecmd,rl-callbacktest,rlbasic}.c
    parse-colors.{c,h}
    readline.pc.in
    configure.ac

Deleted files in readline/:

    configure.in

Regressions:

After the sync there is one testsuite regression, the test
"signal SIGINT" in gdb.gdb/selftest.exp which now FAILs.  Previously,
the readline 6.2 SIGINT handler would temporarily reinstall the
underlying application's SIGINT handler and immediately re-raise SIGINT
so that the orginal handler gets invoked.  But now (since readline 6.3)
its SIGINT handler does not re-raise SIGINT or directly invoke the
original handler; it now sets a flag marking that SIGINT was raised, and
waits until readline explicitly has control to call the application's
SIGINT handler.  Anyway, because SIGINT is no longer re-raised from
within readline's SIGINT handler, doing "signal SIGINT" with a stopped
inferior gdb process will no longer resume and then immediately stop the
process (since there is no 2nd SIGINT to immediately catch).  Instead,
the inferior gdb process will now just print "Quit" and continue to run.
So with this commit, this particular test case is adjusted to reflect
this change in behavior (we now have to send a 2nd SIGINT manually to
stop it).

Aside from this one testsuite regression, I personally noticed no
regression in user-visible behavior.  Though I only tested on x86_64
and on i686 Debian Stretch.

Getting this kind of change in at the start of the GDB 7.11 development
cycle will allow us to get a lot of passive testing from developers and
from bleeding-edge users.  [And as new versions of readline 7.0 are
released, I will try to sync our local copy promptly.]

Since the patch is too big to send inline, I pushed it to
users/ppalka/readline-7.0-update.  Hopefully that is more convenient that
sending it as a compressed attachment.

readline/ChangeLog.gdb:

	Import readline 7.0 alpha
	* configure: Regenerate.
	* examples/rlfe/configure: Regenerate.

gdb/ChangeLog:

	* completer.c (gdb_printable_part): Sync with readline function
	it is based off of.

gdb/testsuite/ChangeLog:

	* gdb.gdb/selftest.exp (test_with_self): Update test to now
	expect the GDB inferior to no longer immediately stop after
	being resumed with "signal SIGINT".
---
 gdb/completer.c                     |    2 +-
 gdb/testsuite/gdb.gdb/selftest.exp  |   23 +-
 readline/CHANGELOG                  |  206 ++
 readline/CHANGES                    |  231 ++
 readline/INSTALL                    |    2 +-
 readline/MANIFEST                   |   11 +-
 readline/Makefile.in                |   74 +-
 readline/NEWS                       |  291 ++-
 readline/README                     |   11 +-
 readline/aclocal.m4                 |   38 +-
 readline/bind.c                     |  342 ++-
 readline/callback.c                 |   70 +-
 readline/chardefs.h                 |   18 +-
 readline/colors.c                   |  279 +++
 readline/colors.h                   |  126 ++
 readline/complete.c                 |  487 ++++-
 readline/config.h.in                |   54 +-
 readline/configure                  |  342 ++-
 readline/configure.ac               |  308 +++
 readline/configure.in               |  304 ---
 readline/display.c                  |  503 +++--
 readline/doc/Makefile.in            |   21 +-
 readline/doc/history.3              |   33 +-
 readline/doc/history.texi           |   26 +-
 readline/doc/hstech.texi            |   16 +-
 readline/doc/hsuser.texi            |   40 +-
 readline/doc/readline.3             |  166 +-
 readline/doc/rlman.texi             |   27 +-
 readline/doc/rltech.texi            |  239 ++-
 readline/doc/rluser.texi            |  317 ++-
 readline/doc/rluserman.texi         |   27 +-
 readline/doc/texi2dvi               | 2336 ++++++++++++++++-----
 readline/doc/texi2html              |    6 +-
 readline/doc/version.texi           |   12 +-
 readline/emacs_keymap.c             |    6 -
 readline/examples/Makefile.in       |   40 +-
 readline/examples/excallback.c      |    7 +-
 readline/examples/hist_erasedups.c  |  121 ++
 readline/examples/hist_purgecmd.c   |  151 ++
 readline/examples/readlinebuf.h     |    6 +-
 readline/examples/rl-callbacktest.c |   90 +
 readline/examples/rlbasic.c         |   28 +
 readline/examples/rlfe/config.h.in  |    6 +-
 readline/examples/rlfe/configure    | 3936 +++++++++++++----------------------
 readline/examples/rlfe/configure.in |    6 +-
 readline/examples/rlfe/extern.h     |    2 +-
 readline/examples/rlfe/os.h         |    8 +-
 readline/examples/rlfe/rlfe.c       |    9 +-
 readline/examples/rlptytest.c       |    6 +-
 readline/funmap.c                   |   11 +-
 readline/histexpand.c               |   83 +-
 readline/histfile.c                 |  274 ++-
 readline/history.c                  |   23 +-
 readline/history.h                  |    6 +-
 readline/input.c                    |  110 +-
 readline/isearch.c                  |  141 +-
 readline/kill.c                     |  102 +-
 readline/macro.c                    |   42 +-
 readline/mbutil.c                   |   11 +-
 readline/misc.c                     |   41 +-
 readline/nls.c                      |   35 +-
 readline/parens.c                   |   26 +-
 readline/parse-colors.c             |  440 ++++
 readline/parse-colors.h             |   46 +
 readline/patchlevel                 |    2 +-
 readline/posixdir.h                 |   14 +-
 readline/posixjmp.h                 |   20 +-
 readline/readline.c                 |  236 ++-
 readline/readline.h                 |   54 +-
 readline/readline.pc.in             |   12 +
 readline/rlconf.h                   |   22 +-
 readline/rldefs.h                   |   10 +-
 readline/rlmbutil.h                 |   49 +
 readline/rlprivate.h                |   61 +-
 readline/rlstdc.h                   |   12 +
 readline/rltty.c                    |   47 +-
 readline/rltypedefs.h               |   11 +-
 readline/search.c                   |   98 +-
 readline/shell.c                    |   48 +-
 readline/shlib/Makefile.in          |   87 +-
 readline/signals.c                  |  144 +-
 readline/support/config.guess       |  587 +++---
 readline/support/config.sub         |  332 ++-
 readline/support/mkdist             |   15 +-
 readline/support/shlib-install      |    9 +-
 readline/support/shobj-conf         |   71 +-
 readline/tcap.h                     |    2 +
 readline/terminal.c                 |   64 +-
 readline/text.c                     |   77 +-
 readline/tilde.c                    |    4 +
 readline/undo.c                     |   39 +-
 readline/util.c                     |   94 +-
 readline/vi_keymap.c                |    1 -
 readline/vi_mode.c                  |  164 +-
 readline/xfree.c                    |    7 -
 readline/xmalloc.h                  |    3 -
 96 files changed, 10361 insertions(+), 4836 deletions(-)
 create mode 100644 readline/colors.c
 create mode 100644 readline/colors.h
 create mode 100644 readline/configure.ac
 delete mode 100644 readline/configure.in
 create mode 100644 readline/examples/hist_erasedups.c
 create mode 100644 readline/examples/hist_purgecmd.c
 create mode 100644 readline/examples/rl-callbacktest.c
 create mode 100644 readline/examples/rlbasic.c
 create mode 100644 readline/parse-colors.c
 create mode 100644 readline/parse-colors.h
 create mode 100644 readline/readline.pc.in

Re: [PATCH] Sync readline/ to version 7.0 alpha

[Patrick Palka]

On Tue, Jul 14, 2015 at 10:35 PM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> This patch syncs our upstream copy of readline from version 6.2 to the
> latest version, 7.0 alpha (released July 10 2015).
>
> I essentially copied what was done the last time readline was synced,
> when Jan updated to readline 6.2 in 2011:
> http://sourceware.org/ml/gdb-patches/2011-05/msg00003.html
>
> Procedure:
>
> 1. I extracted the readline-7.0-alpha tarball on top of readline/.
> 2. I deleted all the new files under doc/ that were deliberately omitted
>    before.
> 3. I regenerated readline/configure and readline/examples/rlfe/configure
>    using autoconf 2.64.  No other configure files need regenerating.
> 4. I updated the function gdb_printable_part in completer.c with a
>    trivial change made to the readline function it is based off of,
>    printable_part in readline/complete.c.  There is more work to be done in
>    completer.c to sync it with readline/complete.c, but it is non-trivial
>    and should probably be done separately anyway.
>
> Local patches that had to be reapplied:
>
>     None.  readline 7.0 alpha contains all of our local readline
>     patches.  [This is especially convenient because it allows us forego
>     a consensus on how to manage local patches across readline syncs :)]
>
> New files in readline/:
>
>     colors.{c,h}
>     examples/{hist_erasedups,hist_purgecmd,rl-callbacktest,rlbasic}.c
>     parse-colors.{c,h}
>     readline.pc.in
>     configure.ac
>
> Deleted files in readline/:
>
>     configure.in
>
> Regressions:
>
> After the sync there is one testsuite regression, the test
> "signal SIGINT" in gdb.gdb/selftest.exp which now FAILs.  Previously,
> the readline 6.2 SIGINT handler would temporarily reinstall the
> underlying application's SIGINT handler and immediately re-raise SIGINT
> so that the orginal handler gets invoked.  But now (since readline 6.3)
> its SIGINT handler does not re-raise SIGINT or directly invoke the
> original handler; it now sets a flag marking that SIGINT was raised, and
> waits until readline explicitly has control to call the application's
> SIGINT handler.  Anyway, because SIGINT is no longer re-raised from
> within readline's SIGINT handler, doing "signal SIGINT" with a stopped
> inferior gdb process will no longer resume and then immediately stop the
> process (since there is no 2nd SIGINT to immediately catch).  Instead,
> the inferior gdb process will now just print "Quit" and continue to run.
> So with this commit, this particular test case is adjusted to reflect
> this change in behavior (we now have to send a 2nd SIGINT manually to
> stop it).
>
> Aside from this one testsuite regression, I personally noticed no
> regression in user-visible behavior.  Though I only tested on x86_64
> and on i686 Debian Stretch.
>
> Getting this kind of change in at the start of the GDB 7.11 development
> cycle will allow us to get a lot of passive testing from developers and
> from bleeding-edge users.  [And as new versions of readline 7.0 are
> released, I will try to sync our local copy promptly.]
>
> Since the patch is too big to send inline, I pushed it to
> users/ppalka/readline-7.0-update.  Hopefully that is more convenient that
> sending it as a compressed attachment.
>
> readline/ChangeLog.gdb:
>
>         Import readline 7.0 alpha
>         * configure: Regenerate.
>         * examples/rlfe/configure: Regenerate.
>
> gdb/ChangeLog:
>
>         * completer.c (gdb_printable_part): Sync with readline function
>         it is based off of.
>
> gdb/testsuite/ChangeLog:
>
>         * gdb.gdb/selftest.exp (test_with_self): Update test to now
>         expect the GDB inferior to no longer immediately stop after
>         being resumed with "signal SIGINT".

Ping!

Re: [PATCH] Sync readline/ to version 7.0 alpha

[Pedro Alves]

On 07/15/2015 03:35 AM, Patrick Palka wrote:
> This patch syncs our upstream copy of readline from version 6.2 to the
> latest version, 7.0 alpha (released July 10 2015).
> 
> I essentially copied what was done the last time readline was synced,
> when Jan updated to readline 6.2 in 2011:
> http://sourceware.org/ml/gdb-patches/2011-05/msg00003.html


> Getting this kind of change in at the start of the GDB 7.11 development
> cycle will allow us to get a lot of passive testing from developers and
> from bleeding-edge users.  

I agree; if this helps find readline issues that affect GDB before
readline is released, it'll be a win, because distros tend to use the
system readline instead of the one we bundle.

> [And as new versions of readline 7.0 are
> released, I will try to sync our local copy promptly.]
> 

Thanks.

> Since the patch is too big to send inline, I pushed it to
> users/ppalka/readline-7.0-update.  Hopefully that is more convenient that
> sending it as a compressed attachment.

Indeed it is.  Thanks.

> 
> readline/ChangeLog.gdb:
> 
> 	Import readline 7.0 alpha
> 	* configure: Regenerate.
> 	* examples/rlfe/configure: Regenerate.
> 
> gdb/ChangeLog:
> 
> 	* completer.c (gdb_printable_part): Sync with readline function
> 	it is based off of.
> 
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.gdb/selftest.exp (test_with_self): Update test to now
> 	expect the GDB inferior to no longer immediately stop after
> 	being resumed with "signal SIGINT".

Looks good to me.

Thanks,
Pedro Alves

Re: [PATCH] Sync readline/ to version 7.0 alpha

[Patrick Palka]

On Fri, Jul 24, 2015 at 4:45 AM, Pedro Alves <palves@redhat.com> wrote:
> On 07/15/2015 03:35 AM, Patrick Palka wrote:
>> This patch syncs our upstream copy of readline from version 6.2 to the
>> latest version, 7.0 alpha (released July 10 2015).
>>
>> I essentially copied what was done the last time readline was synced,
>> when Jan updated to readline 6.2 in 2011:
>> http://sourceware.org/ml/gdb-patches/2011-05/msg00003.html
>
>
>> Getting this kind of change in at the start of the GDB 7.11 development
>> cycle will allow us to get a lot of passive testing from developers and
>> from bleeding-edge users.
>
> I agree; if this helps find readline issues that affect GDB before
> readline is released, it'll be a win, because distros tend to use the
> system readline instead of the one we bundle.
>
>> [And as new versions of readline 7.0 are
>> released, I will try to sync our local copy promptly.]
>>
>
> Thanks.
>
>> Since the patch is too big to send inline, I pushed it to
>> users/ppalka/readline-7.0-update.  Hopefully that is more convenient that
>> sending it as a compressed attachment.
>
> Indeed it is.  Thanks.
>
>>
>> readline/ChangeLog.gdb:
>>
>>       Import readline 7.0 alpha
>>       * configure: Regenerate.
>>       * examples/rlfe/configure: Regenerate.
>>
>> gdb/ChangeLog:
>>
>>       * completer.c (gdb_printable_part): Sync with readline function
>>       it is based off of.
>>
>> gdb/testsuite/ChangeLog:
>>
>>       * gdb.gdb/selftest.exp (test_with_self): Update test to now
>>       expect the GDB inferior to no longer immediately stop after
>>       being resumed with "signal SIGINT".
>
> Looks good to me.

Thanks for reviewing.  I pushed this patch earlier today and not
surprisingly the buildbot caught some build failures.  The ultimate
cause of these failures is that readline now builds shared libraries
by default alongside static libraries.  I pushed a patch that disables
the building of readline's shared libraries by default.

>
> Thanks,
> Pedro Alves
>

Re: [PATCH] Sync readline/ to version 7.0 alpha

[Doug Evans]

On Sat, Jul 25, 2015 at 8:33 AM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> On Fri, Jul 24, 2015 at 4:45 AM, Pedro Alves <palves@redhat.com> wrote:
>> On 07/15/2015 03:35 AM, Patrick Palka wrote:
>>> This patch syncs our upstream copy of readline from version 6.2 to the
>>> latest version, 7.0 alpha (released July 10 2015).
>>>
>>> I essentially copied what was done the last time readline was synced,
>>> when Jan updated to readline 6.2 in 2011:
>>> http://sourceware.org/ml/gdb-patches/2011-05/msg00003.html
>>
>>
>>> Getting this kind of change in at the start of the GDB 7.11 development
>>> cycle will allow us to get a lot of passive testing from developers and
>>> from bleeding-edge users.
>>
>> I agree; if this helps find readline issues that affect GDB before
>> readline is released, it'll be a win, because distros tend to use the
>> system readline instead of the one we bundle.
>>
>>> [And as new versions of readline 7.0 are
>>> released, I will try to sync our local copy promptly.]
>>>
>>
>> Thanks.
>>
>>> Since the patch is too big to send inline, I pushed it to
>>> users/ppalka/readline-7.0-update.  Hopefully that is more convenient that
>>> sending it as a compressed attachment.
>>
>> Indeed it is.  Thanks.
>>
>>>
>>> readline/ChangeLog.gdb:
>>>
>>>       Import readline 7.0 alpha
>>>       * configure: Regenerate.
>>>       * examples/rlfe/configure: Regenerate.
>>>
>>> gdb/ChangeLog:
>>>
>>>       * completer.c (gdb_printable_part): Sync with readline function
>>>       it is based off of.
>>>
>>> gdb/testsuite/ChangeLog:
>>>
>>>       * gdb.gdb/selftest.exp (test_with_self): Update test to now
>>>       expect the GDB inferior to no longer immediately stop after
>>>       being resumed with "signal SIGINT".
>>
>> Looks good to me.
>
> Thanks for reviewing.  I pushed this patch earlier today and not
> surprisingly the buildbot caught some build failures.  The ultimate
> cause of these failures is that readline now builds shared libraries
> by default alongside static libraries.  I pushed a patch that disables
> the building of readline's shared libraries by default.

Another build failure:

../../testsuite-random/readline/display.c: In function ‘rl_redisplay’:
../../testsuite-random/readline/display.c:1032:12: error: ‘mb_cur_max’
undeclared (first use in this function)
        if (mb_cur_max > 1 && rl_byte_oriented == 0)
            ^
../../testsuite-random/readline/display.c:1032:12: note: each
undeclared identifier is reported only once for each function it
appears in

A lot of uses of mb_cur_max are no longer protected with
#ifdef HANDLE_MULTIBYTE
yet its definition (in rl_redisplay) still is.

I don't know what the right fix is, but we need to get this
fixed asap.

Re: [PATCH] Sync readline/ to version 7.0 alpha

[Patrick Palka]

On Sat, Jul 25, 2015 at 3:15 PM, Doug Evans <xdje42@gmail.com> wrote:
> On Sat, Jul 25, 2015 at 8:33 AM, Patrick Palka <patrick@parcs.ath.cx> wrote:
>> On Fri, Jul 24, 2015 at 4:45 AM, Pedro Alves <palves@redhat.com> wrote:
>>> On 07/15/2015 03:35 AM, Patrick Palka wrote:
>>>> This patch syncs our upstream copy of readline from version 6.2 to the
>>>> latest version, 7.0 alpha (released July 10 2015).
>>>>
>>>> I essentially copied what was done the last time readline was synced,
>>>> when Jan updated to readline 6.2 in 2011:
>>>> http://sourceware.org/ml/gdb-patches/2011-05/msg00003.html
>>>
>>>
>>>> Getting this kind of change in at the start of the GDB 7.11 development
>>>> cycle will allow us to get a lot of passive testing from developers and
>>>> from bleeding-edge users.
>>>
>>> I agree; if this helps find readline issues that affect GDB before
>>> readline is released, it'll be a win, because distros tend to use the
>>> system readline instead of the one we bundle.
>>>
>>>> [And as new versions of readline 7.0 are
>>>> released, I will try to sync our local copy promptly.]
>>>>
>>>
>>> Thanks.
>>>
>>>> Since the patch is too big to send inline, I pushed it to
>>>> users/ppalka/readline-7.0-update.  Hopefully that is more convenient that
>>>> sending it as a compressed attachment.
>>>
>>> Indeed it is.  Thanks.
>>>
>>>>
>>>> readline/ChangeLog.gdb:
>>>>
>>>>       Import readline 7.0 alpha
>>>>       * configure: Regenerate.
>>>>       * examples/rlfe/configure: Regenerate.
>>>>
>>>> gdb/ChangeLog:
>>>>
>>>>       * completer.c (gdb_printable_part): Sync with readline function
>>>>       it is based off of.
>>>>
>>>> gdb/testsuite/ChangeLog:
>>>>
>>>>       * gdb.gdb/selftest.exp (test_with_self): Update test to now
>>>>       expect the GDB inferior to no longer immediately stop after
>>>>       being resumed with "signal SIGINT".
>>>
>>> Looks good to me.
>>
>> Thanks for reviewing.  I pushed this patch earlier today and not
>> surprisingly the buildbot caught some build failures.  The ultimate
>> cause of these failures is that readline now builds shared libraries
>> by default alongside static libraries.  I pushed a patch that disables
>> the building of readline's shared libraries by default.
>
> Another build failure:
>
> ../../testsuite-random/readline/display.c: In function ‘rl_redisplay’:
> ../../testsuite-random/readline/display.c:1032:12: error: ‘mb_cur_max’
> undeclared (first use in this function)
>         if (mb_cur_max > 1 && rl_byte_oriented == 0)
>             ^
> ../../testsuite-random/readline/display.c:1032:12: note: each
> undeclared identifier is reported only once for each function it
> appears in
>
> A lot of uses of mb_cur_max are no longer protected with
> #ifdef HANDLE_MULTIBYTE
> yet its definition (in rl_redisplay) still is.
>
> I don't know what the right fix is, but we need to get this
> fixed asap.

Hmm, I'll just revert this patch for now since I also noticed that I
failed to reapply some local changes to readline's configure.in that
were hid by the rename to configure.ac.  Also, the buildbots are
showing new regressions for e.g. AIX.  I won't have enough time over
the next few days to manage the fallout of this change.