* [PATCH] gdb/infcmd: remove redundant clear_proceed_status call
@ 2020-10-06 16:36 Tankut Baris Aktemur
2020-10-07 3:22 ` Simon Marchi
0 siblings, 1 reply; 2+ messages in thread
From: Tankut Baris Aktemur @ 2020-10-06 16:36 UTC (permalink / raw)
To: gdb-patches
In `attach_command`, there is a call to `init_wait_for_inferior`
followed by a call to `clear_proceed_status`. However,
`init_wait_for_inferior` already calls `clear_proceed_status`. Remove
the redundant call.
Regression-tested on X86_64 Linux.
gdb/ChangeLog:
2020-10-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* infcmd.c (attach_command): Remove the redundant call to
`clear_proceed_status`.
---
gdb/infcmd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index d8f95977a18..498089fdb52 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -2619,7 +2619,6 @@ attach_command (const char *args, int from_tty)
/* Set up execution context to know that we should return from
wait_for_inferior as soon as the target reports a stop. */
init_wait_for_inferior ();
- clear_proceed_status (0);
inferior->needs_setup = 1;
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gdb/infcmd: remove redundant clear_proceed_status call
2020-10-06 16:36 [PATCH] gdb/infcmd: remove redundant clear_proceed_status call Tankut Baris Aktemur
@ 2020-10-07 3:22 ` Simon Marchi
0 siblings, 0 replies; 2+ messages in thread
From: Simon Marchi @ 2020-10-07 3:22 UTC (permalink / raw)
To: Tankut Baris Aktemur, gdb-patches
On 2020-10-06 12:36 p.m., Tankut Baris Aktemur via Gdb-patches wrote:
> In `attach_command`, there is a call to `init_wait_for_inferior`
> followed by a call to `clear_proceed_status`. However,
> `init_wait_for_inferior` already calls `clear_proceed_status`. Remove
> the redundant call.
>
> Regression-tested on X86_64 Linux.
Thanks, that LGTM.
Simon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-07 3:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-06 16:36 [PATCH] gdb/infcmd: remove redundant clear_proceed_status call Tankut Baris Aktemur
2020-10-07 3:22 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).